fix: NetworkVariable change prior to ownership change using distributed authority topology fails to sync NetworkVariable - #4107
Open
NoelStephensUnity wants to merge 3 commits into
Conversation
Removing the additional authority check as it is not needed. Fixing a very edge case scenario that shouldn't happen but in the event it does when finding objects by type within a specific scene, if the scene is invalid then use an empty array for the found objects.
…ge-before-ownership-change
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop-2.0.0 #4107 +/- ##
==============================================
Coverage 73.88% 73.89%
==============================================
Files 172 172
Lines 28013 28020 +7
==============================================
+ Hits 20698 20705 +7
Misses 7315 7315
Flags with carried forward coverage won't be shown. Click here to find out more.
|
michalChrobot
approved these changes
Jul 28, 2026
michalChrobot
left a comment
michalChrobot
left a comment
Member
There was a problem hiding this comment.
looks good from what I understand
FelixWentworth-Unity
approved these changes
Jul 28, 2026
FelixWentworth-Unity
left a comment
FelixWentworth-Unity
left a comment
There was a problem hiding this comment.
checked changes against repro project - lgtm!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This resolves the issue where in a distributed authority session changing a NetworkVariable prior to changing ownership in the same call-stack would result in the NetworkVariable not being synchronized.
Jira ticket
UUM-148291
Changelog
NetworkVariableprior to changing ownership in the same call-stack would result in theNetworkVariablenot being synchronized.Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Up-port
This will require an up-port.
Backports
No backport is required.