test: cover PRIVMSG error replies (411/412/401) - #14
Merged
Conversation
PrivateMessage/ChannelMessage only proved the happy path. Add the three missing PRIVMSG error cases, matching CommandMessaging.cpp's actual check order (recipient before text, CommandMessaging.cpp:14-24): ERR_NORECIPIENT (no params), ERR_NOTEXTTOSEND (target present, no text — proven with an unresolvable target to confirm the text check runs before findClientByNick), and ERR_NOSUCHNICK (unknown target with text). Multi-target is deliberately not tested: ERR_TOOMANYTARGETS doesn't exist in this codebase and comma-separated targets are out of the mandatory subject's scope. Verified the ERR_NOSUCHNICK check actually gates behavior by commenting out its sendReply() in CommandMessaging.cpp, confirming the new test failed, then reverting (src/ diff came back clean). Updates COVERAGE.md row D from partial to covered, citing the three new numerics plus the pre-existing 404 coverage, and notes multi-target as out-of-scope rather than an open gap. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PrivateMessage/ChannelMessage only proved the happy path. Add the three missing PRIVMSG error cases, matching CommandMessaging.cpp's actual check order (recipient before text, CommandMessaging.cpp:14-24): ERR_NORECIPIENT (no params), ERR_NOTEXTTOSEND (target present, no text — proven with an unresolvable target to confirm the text check runs before findClientByNick), and ERR_NOSUCHNICK (unknown target with text). Multi-target is deliberately not tested: ERR_TOOMANYTARGETS doesn't exist in this codebase and comma-separated targets are out of the mandatory subject's scope.
Verified the ERR_NOSUCHNICK check actually gates behavior by commenting out its sendReply() in CommandMessaging.cpp, confirming the new test failed, then reverting (src/ diff came back clean).
Updates COVERAGE.md row D from partial to covered, citing the three new numerics plus the pre-existing 404 coverage, and notes multi-target as out-of-scope rather than an open gap.