Fix/nick truncate not reject - #21
Merged
Merged
Conversation
A NICK over 9 chars got 432 ERR_ERRONEUSNICKNAME, which blocked HexChat: its fallback lengthens the nick on retry, so all attempts failed and the client couldn't connect. Real ircds (Solanum) truncate to the advertised NICKLEN; 432 is also semantically wrong (it's for invalid chars, not length). Character validation still runs over the full untruncated string (invalid char past position 9 → 432, confirmed against Solanum); truncation happens in cmdNick before isNickInUse so two nicks truncating to the same name collide with 433 rather than duplicating.
A client that registers, sends one line, then stays silent with the socket fully open, timestamping recv()==0. Unlike nc (which only exits when its stdin is EOF *and* the socket closes), this measures the server's actual disconnect decision — the distinction that resolved the T2 false positive.
…ut retraction (T2), nc timing trap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.