Issue1#36
Merged
SundermannC merged 22 commits intoUniversal-Variability-Language:masterfrom Jul 11, 2023
Merged
Conversation
This reverts commit 9ab283d.
Member
Member
TobiUUlm
reviewed
Jul 6, 2023
uvls/src/core/module.rs
Outdated
| ); | ||
| } | ||
| } | ||
| Symbol::Attribute(i) => { |
Collaborator
There was a problem hiding this comment.
this value i is unused, i get a warning. please change it to _ or ...
Member
|
The configuration editor and the output configurations look good. However, I think the reasoning for cardinality in combination with tree hierarchy is not optimal. results in here I would expect that not picking any Brake would be valid since it is optional. Similarly, if the brake is changed to mandatory every Brake instance needs to be selected. Here, I would expect that between 1 and 3 need to be selected and not necessarily all. |
Collaborator
|
I totally agree with that, but could we make this a new issue? |
Member
|
Ok, then I will merge this PR for now. @felixrieg, can you create the issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




fixes issue #1
We solved this by adding each instance of the cardinality into the tree.
Notes:
Constrains are not working -> new issue #35
The configuration could be improved