Fix 10 bugs across content.js, popup.js, and background.js#232
Open
Dathwik wants to merge 1 commit into
Open
Conversation
- Fix forEach+splice skipping elements in reminderWatch; use filter instead - Fix missing `found = true` in insertReminders override branch causing duplicate reminders - Fix missing colon in CSS color property in inspectDarkMode (color#hex → color:#hex) - Fix impossible guard `auto_dark && auto_dark === false` in toggleAutoDarkMode - Fix `previous` undeclared variable in changeColorPreset (implicit global) - Fix cross-origin iframe null contentDocument crash in runiframeChecker - Fix cardAssignments undefined TypeError on first dashboard load in loadCardAssignments - Fix splice(i) without deleteCount removing all URLs after index in displayDarkModeFixUrls - Fix JSON.parse without try/catch crashing import input on invalid JSON - Fix searchFor not URL-encoded in theme API requests - Fix "gradent_cards" typo in default options (was orphaning gradient_cards storage key)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
found = truein insertReminders override branch causing duplicate remindersauto_dark && auto_dark === falsein toggleAutoDarkModepreviousundeclared variable in changeColorPreset (implicit global)