feat: add multi select function to experiment area filter#1513
Open
ChongJiaChua wants to merge 10 commits into
Open
feat: add multi select function to experiment area filter#1513ChongJiaChua wants to merge 10 commits into
ChongJiaChua wants to merge 10 commits into
Conversation
ChongJiaChua
changed the title
TCMeldrum
reviewed
May 22, 2026
TCMeldrum
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes UserOfficeProject/issue-tracker/issues/1560
Description
This PR introduces the ability to select and filter by multiple instruments to allow more than one instrument's proposals to be returned at any one time.
Motivation and Context
The change was proposed by a instrument scientist who wanted to view and manage proposals across multiple instruments at the same time. Previously, the filter only allowed selecting a single instrument which limited efficiency.
How Has This Been Tested
Added e2e tests
Fixes
Changes
Frontend: Updated the
InstrumentFiltercomponent to support multiple intrument selections and added helper functions (parseInstrumentQuery,getInstrumentFilterIds) to manage the multi select states.GraphQL API: Replaced the singular
instrumentIdfield with a newinstrumentIdsarray field to support multiple values. (instrumentIdmarked as deprecated to avoid breaking external APIs )Backend: Updated ProposalDataSource and StfcProposalDataSource to handle array-based filtering.
Depends on
Tests included/Docs Updated?