Skip to content

fix: stfc fap export access route fix#1530

Merged
TCMeldrum merged 2 commits into
developfrom
1598-fix-stfc-fap-export
May 27, 2026
Merged

fix: stfc fap export access route fix#1530
TCMeldrum merged 2 commits into
developfrom
1598-fix-stfc-fap-export

Conversation

@TCMeldrum
Copy link
Copy Markdown
Contributor

@TCMeldrum TCMeldrum commented May 22, 2026

Closes UserOfficeProject/issue-tracker#1598

Description

This PR addresses an issue with the STFC FAP export access route.

Motivation and Context

The change is required to correct the value retrieval for the 'Proposed_Route' and 'direct_access_route'. Previously, an incorrect property was being accessed which led to erroneous data being exported.

Changes

  • Updated the property accessed in the value retrieval for 'Proposed_Route' and 'direct_access_route' from 'value.value' to 'value' in the getStfcDataRow function.

How Has This Been Tested

This change has been tested locally by running the FAP export function and verifying the exported data is correct.

How Has This Been Tested?

Fixes Jira Issue

https://jira.ess.eu//browse/

Depends On

Tests included/Docs Updated?

  • I have added tests to cover my changes.
  • All relevant doc has been updated

@TCMeldrum TCMeldrum requested a review from a team as a code owner May 22, 2026 09:40
@TCMeldrum TCMeldrum requested review from Bhaswati1148 and removed request for a team May 22, 2026 09:40
@TCMeldrum TCMeldrum enabled auto-merge May 27, 2026 10:40
@TCMeldrum TCMeldrum disabled auto-merge May 27, 2026 10:41
@TCMeldrum TCMeldrum enabled auto-merge (squash) May 27, 2026 10:41
@TCMeldrum TCMeldrum merged commit 14662bb into develop May 27, 2026
22 checks passed
@TCMeldrum TCMeldrum deleted the 1598-fix-stfc-fap-export branch May 27, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants