feat: Add the ability to set minimum and maximum ratings to VT facilities#4517
Open
CLC0609 wants to merge 17 commits intoVATSIM-UK:mainfrom
Open
feat: Add the ability to set minimum and maximum ratings to VT facilities#4517CLC0609 wants to merge 17 commits intoVATSIM-UK:mainfrom
CLC0609 wants to merge 17 commits intoVATSIM-UK:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
minimum_atc_qualification_id,maximum_atc_qualification_id,minimum_pilot_qualification_idandmaximum_pilot_qualification_idtraining_teamof the facility (atc or pilot).I wasn't sure about using one
minimum_qualification_idandmaximum_qualification_idcolumn instead of splitting them into two separate pairs of columns. The two pairs seemed like a simpler solution but can change to a single pair if this is preferred.Screenshots (if necessary)
Facility Resource
ATC
Pilot
Public facing facility select
ATC
Pilot
requested by WS as a solution to having members without qualifications applying to vist/transfer causing an error during the 90 day check