Fixes #1404 - Stand assignments 'locked' after landing#1761
Open
CLC0609 wants to merge 2 commits intoVATSIM-UK:mainfrom
Open
Fixes #1404 - Stand assignments 'locked' after landing#1761CLC0609 wants to merge 2 commits intoVATSIM-UK:mainfrom
CLC0609 wants to merge 2 commits intoVATSIM-UK:mainfrom
Conversation
|
Contributor
|
@DuckWhsiperer Just to confirm, is this still an issue? |
It was more a feature request/suggestion. If Coby introduced the above and it works then great! I cant say that I've noticed the old behaviour |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1404
I know this issue was opened ages ago so I'm not sure if it's even wanted but I wanted to get some experience at making an edit to the API so I figured might as well try this one.
I've added a function to the
Network Aircraftmodel to find if its landed at it's destination airport by looking at it's proximity to the airfield and it's ground speed. When there is a conflicting assignment, it checks if the aircraft has landed and if it has it won't delete the assignment.This does raise the issue, that the aircraft is now assigned to a stand that another aircraft occupies. However, there is no longer confusion with the stand changing unexpectedly after a taxi instruction has been given.