Skip to content

feat: Notify Users about out of date pack#590

Merged
kristiankunc merged 21 commits intoVATSIM-UK:mainfrom
BenWalker01:ukcp-update-notifs
Feb 2, 2026
Merged

feat: Notify Users about out of date pack#590
kristiankunc merged 21 commits intoVATSIM-UK:mainfrom
BenWalker01:ukcp-update-notifs

Conversation

@BenWalker01
Copy link
Contributor

447341769-3b0152d7-a479-4fcd-9809-110e99e71aea

Fixes #571

@kristiankunc kristiankunc requested a review from Copilot October 21, 2025 18:22

This comment was marked as outdated.

Copy link
Contributor

@kristiankunc kristiankunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd honestly love to see at least partial test coverage on this.

@BenWalker01
Copy link
Contributor Author

I'll write some in a bit

@kristiankunc
Copy link
Contributor

The copilot comments about the files also look sensible, we can just throw an error instantly (which can be surpressed as I assume we don't want to enforce it 100%) + the rest are some nitpicks

@kristiankunc kristiankunc changed the title Fixs #571 - Notify Users about out of date pack Fixes #571 - Notify Users about out of date pack Oct 27, 2025
@kristiankunc kristiankunc requested a review from Copilot November 30, 2025 23:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kristiankunc
Copy link
Contributor

@BenWalker01 still planning on pushing this?

@BenWalker01
Copy link
Contributor Author

Yeah. Will try fix the outstanding comments this evening!

@BenWalker01 BenWalker01 changed the title Fixes #571 - Notify Users about out of date pack feat: Notify Users about out of date pack Jan 28, 2026
@kristiankunc kristiankunc merged commit d1b9c6c into VATSIM-UK:main Feb 2, 2026
3 checks passed
@VATSIMUK
Copy link

VATSIMUK commented Feb 2, 2026

🎉 This PR is included in version 5.18.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UK Controller Pack Outdated Notification

3 participants