Fixed includes and asserts in v1.6.18 release.

[risa2000]

It seems some internal include structure leaked through. The fix:

1. replaces the "system relative" includes of type <#include ...> with project relative includes (of type "#include ..." and fixes the path.
2. comments out the assert macro for which the header is missing.

[JoeLudwig]

Thanks for this. I won't be able to take the MR because the authoritative upstream repo is Perforce, but I can apply the same fixes there.

[HadetTheUndying]

Hey so I'm still getting some build errors with this PR. I'm just trying to build to compile some other projects and this has been a headache and a half.

/home/hadet/projects/openvr/src/vrcommon/strtools_public.cpp:124:2: error: 'va_start' was not declared in this scope
  124 |  va_start( args, pchFormat );
      |  ^~~~~~~~
/home/hadet/projects/openvr/src/vrcommon/strtools_public.cpp:126:2: error: 'va_end' was not declared in this scope
  126 |  va_end( args );
      |  ^~~~~~
make[2]: *** [src/CMakeFiles/openvr_api.dir/build.make:186: src/CMakeFiles/openvr_api.dir/vrcommon/strtools_public.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:113: src/CMakeFiles/openvr_api.dir/all] Error 2
make: *** [Makefile:149: all] Error 2

[okawo80085]

Same comments as in #1558

[okawo80085]

Also @JoeLudwig its been more then 6 months now, is it that hard to push the patched branch to Github? ValveSoftware:master still has a broken build!

[danwillm]

Seems like this is still an issue after the latest update today - is it possible to get a fix for it? Thanks!

[risa2000]

@danwillm Hmm, I can see now that after a year my pull request accumulated some other patches. I guess I should reset it back to the original patch.

[HadetTheUndying]

It's really frustrating that Valve will not turn this into the official repo for this. Having to fetch this remote to fix the build process every time I set up my dev environment