Fix -G "Unix Makefiles" for linux cmake commnad#1618
Closed
guysoft wants to merge 1 commit intoValveSoftware:masterfrom
Closed
Fix -G "Unix Makefiles" for linux cmake commnad#1618guysoft wants to merge 1 commit intoValveSoftware:masterfrom
guysoft wants to merge 1 commit intoValveSoftware:masterfrom
Conversation
Hey, that line has a typo. it should be ``-G "Unix Makefiles"``.
Without this line you get:
```
$ cmake .. -G Makefile -DCMAKE_BUILD_TYPE=Release
CMake Error: Could not create named generator Makefile
Generators
* Unix Makefiles = Generates standard UNIX makefiles.
Green Hills MULTI = Generates Green Hills MULTI files
(experimental, work-in-progress).
...
```
Also - do you know where the binaries are actually built to? I can find it
|
There is a bigger problem with that cmake command, it's making you think you have to use a specific generator to build, that's just plain wrong! Remove the generator argument entirely, there is no generator specific arguments passed so its fine to do that, cmake will choose the default generator installed on the system. It's less confusing that way. |
|
Listen to the guy above. I'm pretty sure his fork fixes it. |
|
I did, i'm saying it can be better. Literally removing the |
Author
|
I was thinking that too, but thought someone wanted to make it more explicit for some reason, can close and open a new one for that. |
guysoft
added a commit
to guysoft/openvr
that referenced
this pull request
Dec 14, 2021
As suggested in ValveSoftware#1618 , removing flags that are not required
Author
|
Closing, see #1619 |
|
That works |
Author
|
@okawo80085 Feel free to comment there :) |
|
Will do! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, that line has a typo. it should be
-G "Unix Makefiles".Without this line you get:
Also
./samples/bin/linux64/helloworldoverlayI had to search for that too.-DCMAKE_PREFIX_PATH=is not required in most distr