fix crash when axes are rendered but m_bShowCubes is toggled off#1829
Open
Pyrolistical wants to merge 1 commit intoValveSoftware:masterfrom
Open
fix crash when axes are rendered but m_bShowCubes is toggled off#1829Pyrolistical wants to merge 1 commit intoValveSoftware:masterfrom
Pyrolistical wants to merge 1 commit intoValveSoftware:masterfrom
Conversation
Author
|
the hellovr_vulkan also seems to have this bug, but I am not setup to test it. this line should be copied to the axes rendering |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
m_bShowCubes can be toggled off by typing the letter c.
axes are rendered when a tracked device controller is connected.
when both m_bShowCubes is false and axes are rendered, the sample crashes.
this is because the g_MVPMatrix constant buffer is not being set for the axes rendering.
what was happening when m_bShowCubes was true, the axes rendering was inheriting the g_MVPMatrix constant buffer for the scene rendering.
this pr fixes the crash by always setting the g_MVPMatrix constant buffer for axes rendering.