Skip to content

Use mapped HGNC name for assay facts gene text when available#597

Merged
bencap merged 1 commit intorelease-2025.6.0from
feature/bencap/450/use-mapped-hgnc-name-for-assay-facts-when-available
Feb 5, 2026
Merged

Use mapped HGNC name for assay facts gene text when available#597
bencap merged 1 commit intorelease-2025.6.0from
feature/bencap/450/use-mapped-hgnc-name-for-assay-facts-when-available

Conversation

@bencap
Copy link
Collaborator

@bencap bencap commented Dec 13, 2025

This pull request improves how gene information is displayed in the AssayFactSheet.vue component. The main focus is to show a clearer and more accurate gene label, handling cases where multiple genes are present or a gene is not specified. This display will now also pull first from the mappedHgncName property, which is based on a more robust HGNC selection strategy as described in VariantEffect/dcd_mapping2#67.

Gene display improvements:

  • Added a new computed property, distinctGenesForTargets, to extract unique mapped HGNC gene names from targetGenes, filtering out empty values.
  • Introduced geneTextForScoreSet, which uses distinctGenesForTargets to determine the gene text: if no mapped gene names are available, it falls back to the original gene name; if there is one unique gene, it displays that; if there are multiple, it displays "Multiple genes".
  • Updated the gene display in the template to use geneTextForScoreSet, defaulting to "Not specified" if no gene is available.

Related code updates:

  • Modified the geneAndYear computed property to use geneTextForScoreSet for consistency in gene name display.

@bencap bencap requested review from jstone-dev and sallybg December 15, 2025 21:54
@bencap bencap marked this pull request as ready for review December 15, 2025 21:55
@bencap bencap changed the base branch from release-2025.5.3 to release-2025.6.0 January 5, 2026 22:30
@bencap bencap force-pushed the feature/bencap/450/use-mapped-hgnc-name-for-assay-facts-when-available branch from e13aac2 to d8aba72 Compare January 31, 2026 00:33
@bencap bencap mentioned this pull request Feb 2, 2026
Copy link
Contributor

@sallybg sallybg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@bencap bencap merged commit 2e4aad4 into release-2025.6.0 Feb 5, 2026
@bencap bencap deleted the feature/bencap/450/use-mapped-hgnc-name-for-assay-facts-when-available branch February 5, 2026 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compute HGNC (or other) symbols for regulatory targets Determine Mapped Target HGNC Name During Mapping

2 participants