Conversation
Adds a `components` method to the Variant class which is a tuple of fully qualified variant strings that comprises the current variant object. The `format_variant` function was refactored into a new function `_format_component_variants`, which returns a list of the component variants of a Variant object. In turn, the __repr__ function uses this class function to return the variant string representation. The `components` method returns the result of this new internal formatting function, with the prefix and transcript identifier prepended to each variant string. For multi-variants, each tuple element is parsable into a single-variant Variant object which comprises the original multi-variant. For single- variants, the single element tuple contains the original variant string.
Fixes an issue where the target identifier string was not captured for multi-variants, which was causing regex validation to fail in cases where the multi-variant had a target identifier. To fix this change, an additional capture group `<variant>` was added as a wrapper around the `<single_variant>` and `<multi_variant>` capture groups. The regex expression was treating the boolean expression as ``` (<target>:<single_variant>)|<multi_variant> ``` and now treats it as ``` <target>:(<single_variant>|<multi_variant>) ``` Additional test cases were added to better capture these potential issues with regex validation of multi-variant (and single-variant) variants in the future.
…s-fail-regex-validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.