Skip to content

simplify BlockContext #5370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
rbran wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

simplify BlockContext #5370

rbran wants to merge 1 commit into from
+27 −21

Conversation

@rbran
Copy link
Contributor

@rbran rbran commented May 6, 2024

No description provided.

@rbran
Copy link
Contributor Author

rbran commented May 6, 2024

It's possible to completely remove the BlockContext and related generics, any BasicBlock<T> and Array<BasicBlock<T>> can be transformed into T and Array<T>, but the Ref struct get in the way. That can only be fully implemented with something similar to #5238.

@ElykDeer ElykDeer added the Component: Rust API Issue needs changes to the Rust API label May 10, 2024
@emesare emesare removed their assignment Jan 25, 2025
@emesare
Copy link
Member

emesare commented Dec 12, 2025

There is another way to remove the BlockContext by new typing each of the four basic block types. I think that will provide consumers a better experience IMO, I will try and make a PR shortly to show what I mean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@emesare emesare

Labels

Component: Rust API Issue needs changes to the Rust API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rbran @emesare @ElykDeer