-
Notifications
You must be signed in to change notification settings - Fork 3
[VPD-404]: Add PT_clisBNBx_25JUN2026 market to core pool and BNB e-mode group #657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
GitGuru7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix simulations for price check, rest looks good to me.
| { | ||
| target: bsctestnet.UNITROLLER, | ||
| signature: "setPoolActive(uint96,bool)", | ||
| params: [EMODE_POOL.id, true], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BNB eMode is already active on mainnet. We can just add a check in the simulations and remove this command from the VIP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed from mainnet b79dff5
vips/vip-790/bsctestnet.ts
Outdated
| { | ||
| target: bsctestnet.UNITROLLER, | ||
| signature: "setIsBorrowAllowed(uint96,address,bool)", | ||
| params: [ | ||
| EMODE_POOL.id, | ||
| EMODE_POOL.marketsConfig.vPT_clisBNB_25JUN2026.address, | ||
| EMODE_POOL.marketsConfig.vPT_clisBNB_25JUN2026.borrowAllowed, | ||
| ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is false by default, so we can remove this comment and just include a check in the simulations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| comptroller: bscmainnet.UNITROLLER, | ||
| isLegacyPool: true, | ||
| }, | ||
| interestRateModel: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for irm, since the asset is supply only, do we really need it ? The value here are just random value ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have taken the IRM values the same as the asBNB market.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine, but it won't have any actual usage, is it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fred-venus Yes, for a supply-only market, the IRM is not functionally used, but a contract may still be assigned for protocol consistency.
|
For the test simulation only issue: But i think it's expected for PT asset, can use |
yes it's realted to PT assest. |
Add PT-clisBNB-25JUN2026 Market to Venus BNB Chain
Introduces PT-clisBNB-25JUN2026 as a new supply-only market in the Core Pool,
borrow paused.Configures risk parameters:
Sets up Pendle oracle.
Adds the market to the BNB emode group.
Configures conversion incentives for relevant converters.
Includes simulation tests for mainnet and testnet.
Updated the
VOTING_PERIODto192384in the index.ts to account for the new block rate in theFermi upgrade.