Skip to content

Conversation

@Debugger022
Copy link
Contributor

@Debugger022 Debugger022 commented Jan 5, 2026

Add PT-clisBNB-25JUN2026 Market to Venus BNB Chain

  • Introduces PT-clisBNB-25JUN2026 as a new supply-only market in the Core Pool, borrow paused.

  • Configures risk parameters:

    • supply cap 25,000,
    • borrow cap 0,
    • collateral factor 0% (core), 87% (emode),
    • liquidation threshold 0% (core), 90% (emode),
    • liquidation incentive 104% (emode).
  • Sets up Pendle oracle.

  • Adds the market to the BNB emode group.

  • Configures conversion incentives for relevant converters.

  • Includes simulation tests for mainnet and testnet.

Updated the VOTING_PERIOD to 192384 in the index.ts to account for the new block rate in the Fermi upgrade.

@Debugger022 Debugger022 marked this pull request as ready for review January 5, 2026 13:16
@Debugger022 Debugger022 self-assigned this Jan 7, 2026
@Debugger022 Debugger022 changed the title [VPD-404]: Add PT_slisBNBx_24JUN2026 market to core pool and BNB e-mode group [VPD-404]: Add PT_clisBNBx_25JUN2026 market to core pool and BNB e-mode group Jan 15, 2026
Copy link
Contributor

@GitGuru7 GitGuru7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix simulations for price check, rest looks good to me.

Comment on lines +245 to +248
{
target: bsctestnet.UNITROLLER,
signature: "setPoolActive(uint96,bool)",
params: [EMODE_POOL.id, true],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BNB eMode is already active on mainnet. We can just add a check in the simulations and remove this command from the VIP.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed from mainnet b79dff5

Comment on lines 274 to 281
{
target: bsctestnet.UNITROLLER,
signature: "setIsBorrowAllowed(uint96,address,bool)",
params: [
EMODE_POOL.id,
EMODE_POOL.marketsConfig.vPT_clisBNB_25JUN2026.address,
EMODE_POOL.marketsConfig.vPT_clisBNB_25JUN2026.borrowAllowed,
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is false by default, so we can remove this comment and just include a check in the simulations.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comptroller: bscmainnet.UNITROLLER,
isLegacyPool: true,
},
interestRateModel: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for irm, since the asset is supply only, do we really need it ? The value here are just random value ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have taken the IRM values the same as the asBNB market.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine, but it won't have any actual usage, is it

Copy link
Contributor Author

@Debugger022 Debugger022 Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fred-venus Yes, for a supply-only market, the IRM is not functionally used, but a contract may still be assigned for protocol consistency.

fred-venus
fred-venus previously approved these changes Jan 16, 2026
@fred-venus
Copy link
Contributor

fred-venus commented Jan 16, 2026

For the test simulation only issue:

  1) Post-VIP behavior
       check price PT_clisBNB_25JUN2026:

      AssertionError: expected 912542998347158442194 to equal 912542911682632512322. The numerical values of the given "ethers.BigNumber" and "ethers.BigNumber" inputs were compared, and they differed.
      + expected - actual

      -912542998347158442194
      +912542911682632512322
     

But i think it's expected for PT asset, can use closeTo maybe ?

@Debugger022
Copy link
Contributor Author

For the test simulation only issue:

  1) Post-VIP behavior
       check price PT_clisBNB_25JUN2026:

      AssertionError: expected 912542998347158442194 to equal 912542911682632512322. The numerical values of the given "ethers.BigNumber" and "ethers.BigNumber" inputs were compared, and they differed.
      + expected - actual

      -912542998347158442194
      +912542911682632512322
     

But i think it's expected for PT asset, can use closeTo maybe ?

yes it's realted to PT assest.
fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants