Skip to content

feat: 👷 Add CI stuff and ruff and basedpyright#12

Open
Paillat-dev wants to merge 3 commits intomainfrom
feat/linter-formatter
Open

feat: 👷 Add CI stuff and ruff and basedpyright#12
Paillat-dev wants to merge 3 commits intomainfrom
feat/linter-formatter

Conversation

@Paillat-dev
Copy link
Collaborator

No description provided.

@Paillat-dev Paillat-dev force-pushed the feat/linter-formatter branch from 8836288 to 51ecce8 Compare February 4, 2026 22:42
@Paillat-dev Paillat-dev requested a review from ToothyDev February 4, 2026 22:42
@ToothyDev ToothyDev linked an issue Feb 4, 2026 that may be closed by this pull request
@Paillat-dev Paillat-dev force-pushed the feat/linter-formatter branch from 63af9f8 to 51ecce8 Compare February 4, 2026 22:50
@jab416171 jab416171 requested a review from Copilot February 4, 2026 22:51
@jab416171 jab416171 self-assigned this Feb 4, 2026
@jab416171 jab416171 removed their assignment Feb 4, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds CI/CD infrastructure using GitHub Actions and introduces Ruff as the formatter and linter for the codebase. The PR also applies formatting changes to existing Python source files to comply with the new Ruff configuration.

Changes:

  • Added GitHub Actions workflows for automated quality checks (formatting and linting) on pushes and pull requests
  • Integrated Ruff (v0.15.0) as a development dependency with comprehensive linting rules
  • Applied code formatting (quote style, spacing, line endings) and added type hints across all cog files and the main entry point
  • Constrained Python version to 3.13.x and updated lock file accordingly

Reviewed changes

Copilot reviewed 8 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.github/workflows/CI.yml Main CI workflow that triggers on pushes/PRs to main branch
.github/workflows/quality.yml Reusable workflow defining format and lint check jobs using Ruff
.gitattributes Enforces LF line endings across all text files
pyproject.toml Adds Ruff configuration, dev dependencies, and constrains Python to 3.13.x
uv.lock Updates lock file to reflect Python version constraint and new dependencies (Ruff)
src/__main__.py Applies formatting (double quotes, spacing) and adds return type hints
src/cogs/slash_commands.py Adds return type hints to __init__ and setup functions
src/cogs/message_commands.py Reformats strings to double quotes, fixes docstring style, and adds type hints
src/cogs/user_commands.py Reformats code (spacing, trailing commas) and adds return type hints

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Paillat-dev Paillat-dev marked this pull request as draft February 4, 2026 22:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 10 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI commented Feb 4, 2026

@jab416171 I've opened a new pull request, #13, to work on those changes. Once the pull request is ready, I'll request review from you.

@Paillat-dev Paillat-dev marked this pull request as ready for review February 4, 2026 23:25
@Paillat-dev Paillat-dev changed the title feat: 👷 Add CI stuff and ruff formatter and linter feat: 👷 Add CI stuff and ruff and basedpyright Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add linter + formatter, define rules for these and add to CI

4 participants