Skip to content

Fix some older client issues for mannequins #1166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kennytv merged 2 commits into from
Jan 2, 2026
Merged

Fix some older client issues for mannequins #1166

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfce064
Properly prevent the team from sending CREATE multiple times.
Owen1212055 Jan 2, 2026
b122ccc
Fix typo
Owen1212055 Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions ...viaversion/viabackwards/protocol/v1_21_9to1_21_7/rewriter/EntityPacketRewriter1_21_9.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ public void registerPackets() {
final TrackedEntity trackedEntity = tracker(wrapper.user()).entity(entityId);

trackedEntity.data().put(mannequinData);
sendInitialPlayerInfoUpdate(wrapper.user(), mannequinData, null, new GameProfile.Property[0]);
sendInitialPlayerInfoUpdate(wrapper.user(), mannequinData, new GameProfile.Property[0]);

mannequinData.setPosition(x, y, z);
mannequinData.setRotation(yaw, pitch);
Expand Down Expand Up @@ -260,7 +260,7 @@ private void storeMovementMannequinData(final PacketWrapper wrapper, final boole
}
}

private void sendInitialPlayerInfoUpdate(final UserConnection connection, final MannequinData mannequinData, final @Nullable String nameOverride, final GameProfile.Property[] properties) {
private void sendInitialPlayerInfoUpdate(final UserConnection connection, final MannequinData mannequinData, final GameProfile.Property[] properties) {
final PacketWrapper playerInfo = PacketWrapper.create(ClientboundPackets1_21_6.PLAYER_INFO_UPDATE, connection);

final BitSet actions = new BitSet(8);
Expand All @@ -270,7 +270,7 @@ private void sendInitialPlayerInfoUpdate(final UserConnection connection, final
playerInfo.write(Types.PROFILE_ACTIONS_ENUM1_21_4, actions);
playerInfo.write(Types.VAR_INT, 1); // One entry
playerInfo.write(Types.UUID, mannequinData.uuid());
playerInfo.write(Types.STRING, nameOverride != null ? nameOverride : mannequinData.name());
playerInfo.write(Types.STRING, mannequinData.name());
playerInfo.write(Types.PROFILE_PROPERTY_ARRAY, properties);
playerInfo.write(Types.BOOLEAN, false); // Session info
playerInfo.write(Types.VAR_INT, 0); // Gamemode
Expand Down Expand Up @@ -312,6 +312,7 @@ private void sendPlayerTeamDisplayName(final UserConnection connection, final Ma
addTeam.write(Types.TAG, new StringTag("")); // Suffix
if (!mannequinData.hasTeam()) {
addTeam.write(Types.STRING_ARRAY, new String[]{mannequinData.name()});
mannequinData.setHasTeam(true);
}
addTeam.send(Protocol1_21_9To1_21_7.class);
}
Expand Down Expand Up @@ -423,7 +424,7 @@ protected void registerRewrites() {
playerInfoRemove.send(Protocol1_21_9To1_21_7.class);

// Spawn new entity
sendInitialPlayerInfoUpdate(event.user(), mannequinData, profile.profile().name(), profile.profile().properties());
sendInitialPlayerInfoUpdate(event.user(), mannequinData, profile.profile().properties());

final PacketWrapper spawnEntityPacket = PacketWrapper.create(ClientboundPackets1_21_6.ADD_ENTITY, event.user());
spawnEntityPacket.write(Types.VAR_INT, event.entityId());
Expand Down Expand Up @@ -469,6 +470,11 @@ protected void registerRewrites() {
equipment.send(Protocol1_21_9To1_21_7.class);
}

final PacketWrapper setHeadRotation = PacketWrapper.create(ClientboundPackets1_21_6.ROTATE_HEAD, event.user());
setHeadRotation.write(Types.VAR_INT, event.entityId());
setHeadRotation.write(Types.BYTE, mannequinData.headYaw());
setHeadRotation.send(Protocol1_21_9To1_21_7.class);

if (!isBundling) {
final PacketWrapper bundleStart = PacketWrapper.create(ClientboundPackets1_21_6.BUNDLE_DELIMITER, event.user());
bundleStart.send(Protocol1_21_9To1_21_7.class);
Expand Down