refactor finalize package#1827
Merged
vrutkovs merged 2 commits intoVictoriaMetrics:masterfrom Feb 19, 2026
Merged
Conversation
Contributor
|
thanks for a PR |
vrutkovs
approved these changes
Feb 19, 2026
Collaborator
|
Thank you for the contribution, that looks really good! I updated the description as it doesn't fix all the points in the linked issue, and we don't want Github to auto close it |
Collaborator
|
Could you sign the commit with GPG as its a requirement for contribution? If not we could push the commit ourselves |
529641a to
12c31ba
Compare
Contributor
Author
|
Thanks for filling the gaps for me. As i understand you already resigned commits with your gpg, so i don't need to do it? |
Contributor
|
I've already signed them, thank you! |
vrutkovs
approved these changes
Feb 19, 2026
Collaborator
vrutkovs
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1773
Removed reduntant SafeDelete calls where possible (except of ClusterRoles, orphaned resources)
Removed SafeDeleteForSelectorsWithFinalizer because it is repeats SafeDeleteWithFinalizer logic but with reduntant selector logic and only used in deleteSA.
Summary by cubic
Refactored finalizer logic to remove redundant delete calls, simplify ServiceAccount cleanup, and streamline the crObject interface, reducing API requests and avoiding label-mismatch issues. Fixes #1773.
Written for commit 12c31ba. Summary will update on new commits.