Skip to content

fixed quotation bug for filters #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Amper merged 1 commit into from
Dec 2, 2025
+11 −1
Merged

fixed quotation bug for filters #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/logsql/select.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3458,7 +3458,7 @@ func formatWildcard(val string) string {

func needsQuoteForPattern(val string) bool {
for _, r := range val {
if r != '*' && r != '_' && r != '-' && r != ':' && r != '/' && r != '.' && (r < '0' || r > '9') && (r < 'A' || r > 'Z') && (r < 'a' || r > 'z') {
if r != '*' && r != '_' && r != '-' && r != ':' && (r < '0' || r > '9') && (r < 'A' || r > 'Z') && (r < 'a' || r > 'z') {
return true
}
}
Expand Down
10 changes: 10 additions & 0 deletions lib/logsql/select_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,11 @@ func TestToLogsQLSuccess(t *testing.T) {
sql: "SELECT * FROM logs WHERE message LIKE '_foo'",
expected: "message:~\"^.foo$\"",
},
{
name: "like suffix paths with dots",
sql: "SELECT * FROM logs WHERE RequestPath LIKE '%/favicon.ico' OR RequestPath LIKE '%index.html'",
expected: "(RequestPath:\"*/favicon.ico\" OR RequestPath:\"*index.html\")",
},
{
name: "compare fields equality",
sql: "SELECT * FROM logs WHERE user_id = customer_id",
Expand Down Expand Up @@ -342,6 +347,11 @@ END AS severity FROM logs`,
sql: "SELECT CASE level WHEN 'error' THEN 'critical' WHEN 'warn' THEN 'warning' ELSE 'info' END AS sev FROM logs",
expected: "* | format \"info\" as sev | format if (level:warn) \"warning\" as sev | format if (level:error) \"critical\" as sev | fields sev",
},
{
name: "case expression with like wildcard",
sql: "SELECT ResponseStatus, CASE WHEN RequestPath LIKE ('%/foo') THEN 'foo' ELSE 'unknown' END AS MyType FROM logs",
expected: "* | format \"unknown\" as MyType | format if (RequestPath:\"*/foo\") \"foo\" as MyType | fields ResponseStatus, MyType",
},
{
name: "json value simple path with alias",
sql: "SELECT JSON_VALUE(payload, '$.ip') AS ip FROM logs",
Expand Down