fix lost query and return for get_expressed_genes_by_cell_and_gene_type #266
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in the get_expressed_genes_by_cell_and_gene_type method that was broken after a previous commit. The missing query execution and return logic has been restored.
Key Changes
- Added missing query execution and result processing logic
- Added
verboseparameter for debugging support - Updated return value documentation from "Empty DataFrame" to "False"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@Robbie1977 I've opened a new pull request, #267, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
[WIP] Update get_expressed_genes_by_cell_and_gene_type based on feedback
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Returns a DataFrame with one cluster per row, annotated as the specified cell type (or subtypes). | ||
| Must restrict to a gene type (to prevent overly long gene lists), which can be retrieved using `get_gene_function_filters`. | ||
| If no data is found, returns Empty DataFrame. | ||
| If no data is found, returns False. |
There was a problem hiding this comment.
The docstring incorrectly states 'returns False' when no data is found, but the previous version mentioned 'Empty DataFrame'. Since the method has a return_dataframe parameter that can be True or False, the docstring should clarify what is returned in both cases when no data is found (False for both, or False vs empty dict).
broken after 94938dc but not shown in diff