Skip to content

Support formatting .sbt inputs#4195

Open
Gedochao wants to merge 1 commit intoVirtusLab:mainfrom
Gedochao:fix/format-sbt
Open

Support formatting .sbt inputs#4195
Gedochao wants to merge 1 commit intoVirtusLab:mainfrom
Gedochao:fix/format-sbt

Conversation

@Gedochao
Copy link
Contributor

@Gedochao Gedochao commented Mar 22, 2026

Fixes #4193

Checklist

  • tested the solution locally and it works
  • ran the code formatter (scala-cli fmt .)
  • ran scalafix (./mill -i __.fix)
  • ran reference docs auto-generation (./mill -i 'generate-reference-doc[]'.run)

How much have your relied on LLM-based tools in this contribution?

extensively, Cursor + Claude

How was the solution tested?

unit + integration tests included

@Gedochao Gedochao changed the title Support formatting .sbt inputs Support formatting .sbt inputs Mar 22, 2026
@Gedochao Gedochao force-pushed the fix/format-sbt branch 4 times, most recently from 3322560 to ba1e534 Compare March 23, 2026 12:36
@Gedochao Gedochao marked this pull request as ready for review March 23, 2026 12:41
@Gedochao Gedochao requested review from tgodzik and zielinsky March 23, 2026 12:41
Copy link
Member

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

| def main(args: Array[String]): Unit = println("$message")
|}
|""".stripMargin,
os.rel / "build.sbt" -> """name := "my-project""""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also run scalafmt on build.sbt in that case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we apparently do.
I wasn't aware, either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Formatting doesn't work for sbt files

3 participants