Skip to content

Potential fix for code scanning alert no. 2: Server-side request forgery #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jdfalk wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Potential fix for code scanning alert no. 2: Server-side request forgery #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pages/api/diagnoses/[diagnosisId]/[viewId].js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,12 @@ export default async function handler(req, res) {
const {diagnosisId, viewId} = req.query;
const {textFormat = "md"} = req.query;

// Validate diagnosisId and viewId to be safe path segments
const safeIdRegex = /^[a-zA-Z0-9_-]+$/;
if (!diagnosisId || !viewId)
return res.status(400).json({error: "Diagnosis ID and viewId are required"});
if (!safeIdRegex.test(diagnosisId) || !safeIdRegex.test(viewId))
return res.status(400).json({error: "Invalid diagnosisId or viewId"});

const cacheKey = `diagnosis:${diagnosisId}:${viewId}:${textFormat}`;
const apiUrl = `${config.API_BASE_URL}/libraries/${config.AUDIENCE}/diagnoses/${diagnosisId}`;
Expand Down