Skip to content

ci: Update page deploy for GitHub Actions #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
g497813927 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: Update page deploy for GitHub Actions #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,13 +117,12 @@ jobs:
run: npm --workspace apps/web run build

- name: Deploy Pages (Direct Upload)
uses: cloudflare/pages-action@v1
uses: cloudflare/wrangler-action@v3
with:
apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
accountId: ${{ steps.zone.outputs.account_id }}
projectName: ${{ steps.cfg.outputs.pages_project_name }}
directory: apps/web/dist
branch: main
command:
pages deploy apps/web/dist --project-name "${{ steps.cfg.outputs.pages_project_name }}" --branch main
Comment on lines +124 to +125
Copy link

Copilot AI Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command syntax appears to be formatted incorrectly. In YAML, when the command value spans multiple lines like this with additional indentation, it should either be a single line or use proper YAML multiline syntax. The current format may cause the action to fail or misinterpret the command. The command should be on a single line like: command: pages deploy apps/web/dist --project-name "${{ steps.cfg.outputs.pages_project_name }}" --branch main

Suggested change
command:
pages deploy apps/web/dist --project-name "${{ steps.cfg.outputs.pages_project_name }}" --branch main
command: pages deploy apps/web/dist --project-name "${{ steps.cfg.outputs.pages_project_name }}" --branch main

Copilot uses AI. Check for mistakes.

- name: Bind custom domain + DNS (Pages)
run: node deploy/cf-api.mjs ensure-pages-domain --domain "${{ steps.cfg.outputs.domain }}" --account-id "${{ steps.zone.outputs.account_id }}" --project-name "${{ steps.cfg.outputs.pages_project_name }}" --zone-id "${{ steps.zone.outputs.zone_id }}" --cname-target "${{ steps.cfg.outputs.cname_target }}"
Expand Down