Skip to content

Comments

Adding Caller Id Features#12

Open
djshadowxm82 wants to merge 5 commits intoW3AXL:mainfrom
djshadowxm82:main
Open

Adding Caller Id Features#12
djshadowxm82 wants to merge 5 commits intoW3AXL:mainfrom
djshadowxm82:main

Conversation

@djshadowxm82
Copy link

This pull request focuses on deprecating the sourceIdTimer functionality in the VirtualChannel class. The changes involve commenting out all references to sourceIdTimer, effectively disabling its initialization, usage, and callback logic. Additionally, a minor update ensures the CallerId field is reset during state updates. Below is a breakdown of the most important changes:

Deprecation of sourceIdTimer functionality:

  • Commented out the initialization of sourceIdTimer and its associated callback (sourceIdTimerCallback) in the VirtualChannel constructor to prevent it from being set up (rc2-dvm/VirtualChannel.cs, rc2-dvm/VirtualChannel.csL189-R190).
  • Disabled the sourceIdTimerCallback method by commenting out its implementation, removing the alternating display of the source ID and talkgroup name (rc2-dvm/VirtualChannel.cs, rc2-dvm/VirtualChannel.csL289-R303).
  • Commented out all calls to sourceIdTimer.Start() and sourceIdTimer.Stop() in the P25DataReceived method and resetCall method to stop triggering the timer (rc2-dvm/VirtualChannel.P25.cs, [1] [2]; rc2-dvm/VirtualChannel.cs, [3].
  • Commented out the sourceIdTimer declaration to indicate it is no longer in use (rc2-dvm/VirtualChannel.cs, rc2-dvm/VirtualChannel.csL61-R61).

State management improvement:

  • Added a line to reset dvmRadio.Status.CallerId to an empty string during state updates in the P25DataReceived method, ensuring the caller ID is cleared when transitioning to an idle state (rc2-dvm/VirtualChannel.P25.cs, rc2-dvm/VirtualChannel.P25.csL530-R534).

@W3AXL
Copy link
Owner

W3AXL commented Oct 22, 2025

@djshadowxm82 one quick request before I merge (looks good otherwise) - could you just remove the source ID stuff instead of commenting it out? I'd like to keep the code clean wherever possible

@W3AXL
Copy link
Owner

W3AXL commented Jan 30, 2026

@djshadowxm82 if you can fix those merge conflicts I'll get this merged in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants