Skip to content

Only use set -x when VERBOSE flag is set #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
idlewis wants to merge 1 commit into
base: vNext
Choose a base branch
from
+8 −6
Open

Only use set -x when VERBOSE flag is set #735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ga/latest/kernel/helpers/build/configure.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ fi

. /opt/ibm/helpers/build/internal/logger.sh

set -Eeox pipefail
set -Eeo pipefail

function main() {
##Define variables for XML snippets source and target paths
Expand Down Expand Up @@ -231,4 +231,4 @@ function parseCommaList() {
done
}

main "$@"
main "$@"
2 changes: 1 addition & 1 deletion ga/latest/kernel/helpers/build/features.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
# limitations under the License.
. /opt/ibm/helpers/build/internal/logger.sh

set -Eeox pipefail
set -Eeo pipefail

##Define variables for XML snippets source and target paths
SNIPPETS_SOURCE=/opt/ibm/helpers/build/configuration_snippets
Expand Down
2 changes: 1 addition & 1 deletion ga/latest/kernel/helpers/build/infinispan-client-setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
# limitations under the License.
. /opt/ibm/helpers/build/internal/logger.sh

set -Eeox pipefail
set -Eeo pipefail

pkgcmd=yum
if ! command $pkgcmd
Expand Down
4 changes: 3 additions & 1 deletion ga/latest/kernel/helpers/build/internal/logger.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
function main() {
if [ "$VERBOSE" != "true" ]; then
exec >/dev/null
else
set -x
fi
}

Expand All @@ -27,4 +29,4 @@ function showLogs() {
exec 1>&3 3>&- 2>&4 4>&-
}

main
main
2 changes: 1 addition & 1 deletion ga/latest/kernel/helpers/build/populate_scc.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
# limitations under the License.
. /opt/ibm/helpers/build/internal/logger.sh

set -Eeox pipefail
set -Eeo pipefail

# 32-bit JVMs don't supported multi-layered SCCs.
[ -e "$JAVA_HOME/lib/i386" -o -e "$JAVA_HOME/lib/ppc" -o -e "$JAVA_HOME/lib/s390" ] && exit 0
Expand Down