Support for outputting embeddings#2
Open
joefutrelle wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds penultimate-layer embedding output. A one-time ONNX graph surgery exposes the embedding tensor as a second model output, then
--embeddingscaptures it alongside class scores in the same forward pass and writes it per bin.add_embedding_output.py(new): auto-detects the pre-head tensor (finalGemm/MatMulinput) and adds it to the model's graph outputs;--tensor-nameoverride.cli.py: new--embeddings/--embeddings-only/--embeddings-outfileflags; write_embeddings writes Parquet (pid + embedding as fixed_size_list)sanstorch.py/withtorch.py: capture outputs[1] and accumulate it alongside scores.pyproject.toml: new[embeddings]extra (pyarrow).README: install row, options, and an Embeddings section.Key questions: