Hamlib5 compatibility#4
Open
GeoBaltz wants to merge 4 commits into
Open
Conversation
Don't touch hamlib internal structure - use rig_set_conf() instead.
Compiles on either Hamlib 4.7.x or 5.0. Updates state and port access methods for new Hamlib structures, using macros for backward compatibility. Needs CMakeLists.txt changes to only include new definitions if they exist(4.7.0 or later)
Attempt to get cmake to define variable for existence of include files. Always says it's "" - no include found. Is it because the files are in /usr/local/include? Or is this just wrong?
Author
|
New commit added - fixes use with Hamlib 4.5, 4.6. May even work with 4.4. Builds and runs with Hamlib-5.0.0~git |
Contributor
|
Thanks, George. I'll try to take a look at it this week unless one of the others beats me to it. I might not get to it until after Dayton. I'd also like to collaborate more on Hamlib 5 moving forward. There are some integration matters that we should discuss sooner rather than later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patches to adapt WSJT-X to Hamlib 5.0 changes
Use rig_set_conf() for port setup - remove referencing Hamlib internal structures.
Use new methods/macros to access Hamlib state structures when API functions not adequate.
First two commits allow compilation&execution with either Hamlib 4.7.x or 5.0~git. Third commit is a non-working attempt to broaden that to include 4.6.x and 4.5.x - so far unsuccessful.
Would this be acceptable (if completed)? What does this need, as far as style or formatting?
Comments, PLEASE
73 n3gb