Add unit tests for FridayOfWeek date calculation#27
Merged
WZ merged 2 commits intofix/uncertainty-button-action-idsfrom Feb 17, 2026
Merged
Add unit tests for FridayOfWeek date calculation#27WZ merged 2 commits intofix/uncertainty-button-action-idsfrom
WZ merged 2 commits intofix/uncertainty-button-action-idsfrom
Conversation
9 tasks
Co-authored-by: WZ <719869+WZ@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update uncertainty buttons and report_private improvements
Add unit tests for FridayOfWeek date calculation
Feb 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive unit test coverage for the FridayOfWeek function, which is a critical date calculation utility used in report filename generation and email subject lines. The function had no test coverage prior to this PR, posing a regression risk.
Changes:
- Added
TestFridayOfWeekwith table-driven tests covering basic Monday→Friday conversion, time component preservation, and edge cases at year/month boundaries - Added
TestFridayOfWeekWithDifferentTimezonesto verify timezone/location preservation across UTC, PST, and JST - All tests validate the four critical aspects of date calculation functions: correct date result, weekday validation, time component preservation, and timezone handling
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
FridayOfWeekfunction drives report filename generation and email subjects but had no test coverage, risking regressions in report naming and date labeling.Changes
TestFridayOfWeek: Covers basic Monday→Friday conversion, time component preservation, and edge cases (year/month boundaries)TestFridayOfWeekWithDifferentTimezones: Verifies timezone/location preservation across UTC, PST, JSTAll tests verify the four critical aspects of date calculation functions: correct date result, weekday validation, time preservation, and timezone handling.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.