Improve error handling in GetArray functions#162
Closed
XxXAdvisaryXxX wants to merge 1 commit intoWaspScripts:mainfrom
Closed
Improve error handling in GetArray functions#162XxXAdvisaryXxX wants to merge 1 commit intoWaspScripts:mainfrom
XxXAdvisaryXxX wants to merge 1 commit intoWaspScripts:mainfrom
Conversation
Added some error handling. If you search for an item that isnt in the database; we get memory access issues when trying to access the returned jsonitem. This way protects the lib from getting access errors. The user will have to do their own error handling on their end if they ever decide to use it. This only happens if you have a typo or the item isnt in the database. Perhaps you have a better way to handle it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some error handling. If you search for an item that isnt in the database; we get memory access issues when trying to access the returned jsonitem.
This way protects the lib from getting access errors. The user will have to do their own error handling on their end if they ever decide to use it.
This only happens if you have a typo or the item isnt in the database. Perhaps you have a better way to handle it?