Pull latest version of photogrammetry fitting code#12
Open
nickwp wants to merge 5 commits intoWatChPhoto:masterfrom
Open
Pull latest version of photogrammetry fitting code#12nickwp wants to merge 5 commits intoWatChPhoto:masterfrom
nickwp wants to merge 5 commits intoWatChPhoto:masterfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
So this is an updated result from what you showed at June 2021 SK CM? What exactly has changed? So far I only see the addition of fixing labeling of image Could you make a report describing these developments? Also, should WCTE stuff be in separate PR? Or no need to review? |
|
Oh sorry, the SK stuff was from December 2021?? Now I'm more confused... |
msekatchev
approved these changes
Jun 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds code for extracting error estimates from the SK photogrammetry fit.
Also adds some alternative fitting options to the fitting code and updated SK ring fit itself.