Skip to content

Pull latest version of photogrammetry fitting code#12

Open
nickwp wants to merge 5 commits intoWatChPhoto:masterfrom
nickwp:master
Open

Pull latest version of photogrammetry fitting code#12
nickwp wants to merge 5 commits intoWatChPhoto:masterfrom
nickwp:master

Conversation

@nickwp
Copy link
Collaborator

@nickwp nickwp commented Dec 2, 2021

Adds code for extracting error estimates from the SK photogrammetry fit.
Also adds some alternative fitting options to the fitting code and updated SK ring fit itself.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@pdeperio
Copy link

pdeperio commented Jun 8, 2022

So this is an updated result from what you showed at June 2021 SK CM?

What exactly has changed? So far I only see the addition of fixing labeling of image 758 (though the image ID labels on overhead plot seem to have disappeared so I can't easily tell how it's changed, but looks like not much, comparing the figures). Then I see the results also changed slightly, e.g. Radial (tangential) position error mean from 4.17 (1.28) to 3.74 (1.15) cm.

Could you make a report describing these developments?

Also, should WCTE stuff be in separate PR? Or no need to review?

@pdeperio
Copy link

pdeperio commented Jun 8, 2022

Oh sorry, the SK stuff was from December 2021?? Now I'm more confused...

@pdeperio pdeperio requested a review from msekatchev June 9, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants