fix: Linux .run installer with proper install script, desktop entry, and bundled icon#48
Merged
Merged
Conversation
…and bundled icon - Add scripts/water-install.sh: install script that copies binary to ~/.local/bin/, icon to ~/.local/share/icons/, desktop entry to ~/.local/share/applications/, and Mesa libs to ~/.local/lib/water/ - Add scripts/water.desktop: XDG desktop entry template with placeholder paths substituted at install time - Update Makefile _bundle-linux-mesa target to include the desktop file and install script in the .run payload, and use install.sh as the makeself startup script instead of the launcher - Icon (logo-only.png) is bundled as icon.png in the .run payload
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Linux
.runself-extracting installer to produce a complete, polished installation experience instead of just extracting and running in-place.Changes
New files
scripts/water-install.sh— Install script executed by the.runinstaller that:~/.local/bin/Water.bin~/.local/bin/Water(with Mesa fallback)~/.local/lib/water/~/.local/share/icons/water.png.desktopfile to~/.local/share/applications/water.desktopscripts/water.desktop— XDG desktop entry template with@BIN_DIR@and@ICON_DIR@placeholders that are substituted at install time with the actual pathsModified files
Makefile— Updated_bundle-linux-mesatarget to:.desktopfile and install script in the.runpayloadinstall.shas the makeself startup script (instead of the launcher)logo-only.png) continues to be bundled asicon.pngin the payload.run payload structure
Install locations
~/.local/bin/Water.bin~/.local/bin/Water~/.local/lib/water/~/.local/share/icons/water.png~/.local/share/applications/water.desktopBuilt for stellar.foundation.us by Kilo for Slack