fix: Linux .run installers bundle all icons/assets and install properly#49
Merged
Merged
Conversation
…operly - Add scripts/linux-install.sh: full installer that copies binary, icons, Mesa libs to /opt/Water, creates .desktop entry, installs XDG icons, and creates /usr/local/bin/water symlink - Add scripts/linux-uninstall.sh: clean uninstaller - Update Makefile _bundle-linux-mesa target to: - Bundle ALL icons (logo.png, logo-only.png, vscode.png) into icons/ dir - Bundle install.sh into the .run archive - Validate all required assets exist before bundling (no silent fallbacks) - Verify bundled contents before creating .run - Run install.sh (not launcher) when .run is executed - Update water-launcher.sh with icons/ directory documentation - No || true on critical icon/asset bundling steps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linux
.runself-extracting installers now produce complete installers that bundle all icons and assets, and properly install the application with desktop integration.Problem
Previously, the
.runinstaller only bundled a single icon (icon.png) and ran the launcher script directly when extracted — it didn't actually install anything to a permanent location or create desktop entries.Changes
New files
scripts/linux-install.sh— Full installer script that:/opt/Water/.desktopentry in~/.local/share/applications/~/.local/share/icons/hicolor/(48x48, 128x128, 256x256, scalable)/usr/local/bin/watersymlink for PATH accessscripts/linux-uninstall.sh— Clean uninstaller that removes all installed filesModified files
Makefile(_bundle-linux-mesatarget):logo.png,logo-only.png,vscode.pngintoicons/directoryinstall.shinto the.runarchive.run.runnow executesinstall.sh(not the launcher directly)scripts/water-launcher.sh— Updated documentation to reflect new directory layout withicons/directoryWhat the .run installer does when run
install.shwhich:/opt/Water/bin/and/opt/Water//opt/Water/icons/and XDG icon directories/opt/Water/lib/ai.water.app.desktopwith proper icon references/usr/local/bin/watersymlinkBuild safety
|| true)Built for stellar.foundation.us by Kilo for Slack