fix: Linux .run installers produce complete packages with icons, assets, and desktop integration#50
Merged
Conversation
…ration
- Add scripts/linux-install.sh: proper installer that handles desktop
integration (XDG .desktop file, icons in hicolor theme, ~/.local/bin
symlink) when the .run is executed
- Update Makefile _bundle-linux-mesa target to:
- Bundle ALL asset files (logo.png, logo-only.png, vscode.png) into
assets/ directory inside the .run
- Validate all asset files exist before packaging (no silent fallbacks)
- Verify bundle contents (binary, launcher, install script, assets)
before creating the .run
- Use install.sh as the makeself entry point instead of the launcher
- Add ASSET_DIR and ASSET_FILES variables to Makefile for centralized
asset management
- Add pre-build validation in release-linux target to fail fast if any
required files are missing
The .run installer now:
1. Extracts to a temp directory
2. Runs install.sh which copies everything to ~/.local/share/water-ai/
3. Installs icons to ~/.local/share/icons/hicolor/*/apps/
4. Creates a .desktop file in ~/.local/share/applications/
5. Creates a symlink in ~/.local/bin/water
6. Binary remains statically linked (except X11/OpenGL)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the Linux release builds to produce complete
.runinstaller files that include all icons, assets, and proper desktop integration.Problem
The existing Linux
.runinstallers only bundled a singleicon.pngand used the launcher script as the makeself entry point. This meant:.desktopfile, no icon installation to XDG locationsChanges
New:
scripts/linux-install.shA proper installer script that runs when the
.runis executed:~/.local/share/water-ai/~/.local/share/icons/hicolor/{256x256,128x128,64x64,48x48,scalable}/apps/.desktopfile in~/.local/share/applications/with proper icon references~/.local/bin/watersymlink for CLI accessUpdated:
MakefileASSET_DIRandASSET_FILESvariables for centralized asset management_bundle-linux-mesatarget now:assets/directory.runinstall.shas the makeself entry point instead of the launcherrelease-linuxtarget validates all required files upfront before building binariesWhat the .run installer does now
install.shwhich:~/.local/share/water-ai/.desktopfile for app menu integrationBuild safety
|| trueon critical stepsmakeselfrunsRelated to #46, #47
Built for stellar.foundation.us by Kilo for Slack