fix: detach tun fd ownership to prevent fdsan double-close crash#23
Merged
Conversation
Use ParcelFileDescriptor.detachFd() instead of .fd when passing the TUN file descriptor to Rust. This transfers FD ownership to the Rust side, so the subsequent vpnInterface?.close() in cleanup() no longer closes the same FD — avoiding the fdsan SIGABRT. "fdsan: attempted to close file descriptor X, expected to be unowned, actually owned by ParcelFileDescriptor" Signed-off-by: iHsin <sun@ihsin.dev> Assisted-by: OpenClaw:deepseek-v4-flash
Signed-off-by: iHsin <sun@ihsin.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
App crashes with
fdsan: attempted to close file descriptor X, expected to be unowned, actually owned by ParcelFileDescriptoron shutdown, leading to SIGABRT.Root cause
The TUN file descriptor was shared between Kotlin and Rust — both sides tried to
close()it. Android's fdsan detects this double-close and kills the process.Fix
Use
ParcelFileDescriptor.detachFd()instead of.fdwhen passing the FD to Rust. This transfers FD ownership to the Rust side; subsequentvpnInterface?.close()in cleanup becomes a no-op for the real FD.Commits
a375296fix: detach tun fd ownership to prevent fdsan double-close crashed5de63chore: bump version to 0.4.1