[pull] master from microsoft:master

.github/actions/spelling/allow.txt

@@ -10,13 +10,15 @@ bcdboot
 checkboxes
 cla
 clonemedium
+Cloudflight
 codeowner
 codeowners
 Contoso
 diffs
 DISM
 dism
 distro
+dsc
 Entra
 Esco
 ESRP
@@ -27,6 +29,7 @@ fnt
 ftp
 github
 GPT
+HKLM
 Homeserver
 homeservers
 https
@@ -68,6 +71,8 @@ ranhpa
 ranpha
 redirector
 Redistributables
+restsource
+rewinged
 Runtimes
 russellbanks
 screenshots
@@ -81,6 +86,7 @@ Testplan
 toolset
 Trenly
 ttc
+UAC
 ubuntu
 UEFI
 unassign

.github/policies/labelAdded.validationCompleted.yml

@@ -1,4 +1,4 @@
-id: labelAdded.validationHttpError
+id: labelAdded.validationCompleted
 name: GitOps.PullRequestIssueManagement
 description: Handlers when "Validation-Completed" label is added
 owner:
@@ -11,6 +11,7 @@ configuration:
       - description: >-
           When the label "Validation-Completed" is added to a pull request and the "Moderator-Approved" label is not present
           * Add a reply notifying the issue author
+          * Remove the Validation-Guide label
         if:
           - payloadType: Pull_Request
           - labelAdded:
@@ -26,6 +27,8 @@ configuration:
                 label: Publisher-Verified
           - isOpen
         then:
+          - removeLabel:
+              label: Validation-Guide
           - addReply:
               reply: >-
                 The check-in policies require a moderator to approve PRs from the community.

.github/policies/labelManagement.assignIcmUsersAndModerators.yml

@@ -1,4 +1,4 @@
-id: labelAdded.assignIcmUsersAndModerators
+id: labelManagement.assignIcmUsersAndModerators
 name: GitOps.PullRequestIssueManagement
 description: When these labels are added, the ICM Primary and secondary user should be assigned
 owner:

Tools/ManualValidation/ManualValidationPipeline.cs

@@ -3979,24 +3979,24 @@ public void AddValidationData(string PackageIdentifier,string gitHubUserName = "
 		//Extend/reference CredWriteW as CredWrite.
 
 		[DllImport("Advapi32.dll", SetLastError = true, EntryPoint = "CredFree", CharSet = CharSet.Unicode)]
-		private static extern bool CredRelease([In] IntPtr credentialPtr);
-		//Extend/reference CredFree as CredWrite.
+		private static extern void CredRelease([In] IntPtr credentialPtr);
+		//Extend/reference CredFree as CredRelease.
 
 		public static Credential GetUserCredential(string target) {
 			CredentialMem credMem;
 			IntPtr credPtr;
 			if (CredRead(target, 1, 0, out credPtr)) { //If found, returns true and adds to credPtr, else false and error. 
-				credMem = Marshal.PtrToStructure<CredentialMem>(credPtr); 
-				//"Marshals data from an unmanaged block of memory to a newly allocated managed object of the type specified by a generic type parameter."
-				byte[] passwordBytes = new byte[credMem.credentialBlobSize]; //Make a new byte array passwordBytes of size credentialBlobSize.
-				Marshal.Copy(credMem.credentialBlob, passwordBytes, 0, credMem.credentialBlobSize); 
-				//Copies data from an unmanaged memory pointer to a managed 8-bit unsigned integer array.
-				//
-				Credential cred = new Credential(credMem.targetName, credMem.userName, Encoding.Unicode.GetString(passwordBytes)); //Make a new Credential object cred.
-				//Original example doesn't include these:
-				CredRelease(credPtr);
-				CredRelease(credMem.credentialBlob);
-				return cred;
+				try {
+					credMem = Marshal.PtrToStructure<CredentialMem>(credPtr);
+					//"Marshals data from an unmanaged block of memory to a newly allocated managed object of the type specified by a generic type parameter."
+					byte[] passwordBytes = new byte[credMem.credentialBlobSize]; //Make a new byte array passwordBytes of size credentialBlobSize.
+					Marshal.Copy(credMem.credentialBlob, passwordBytes, 0, credMem.credentialBlobSize);
+					//Copies data from an unmanaged memory pointer to a managed 8-bit unsigned integer array.
+					return new Credential(credMem.targetName, credMem.userName, Encoding.Unicode.GetString(passwordBytes)); //Make a new Credential object cred.
+				} finally {
+					//credentialBlob is an interior pointer into credPtr; free the buffer once via CredFree.
+					if (credPtr != IntPtr.Zero) { CredRelease(credPtr); }
+				}
 			} else {
 				throw new Exception("Failed to retrieve credentials");
 			}
@@ -4014,11 +4014,14 @@ public static void SetUserCredential(string target, string userName, string pass
 			userCredential.credentialBlobSize = (int)bpassword.Length;
 			userCredential.credentialBlob = Marshal.StringToCoTaskMemUni(password);
 			//If write fails, emit last error. 
-			if (!CredWrite(ref userCredential, 0)) {
-				throw new System.ComponentModel.Win32Exception(Marshal.GetLastWin32Error());
+			try {
+				if (!CredWrite(ref userCredential, 0)) {
+					throw new System.ComponentModel.Win32Exception(Marshal.GetLastWin32Error());
+				}
+			} finally {
+				//Match StringToCoTaskMemUni allocation with FreeCoTaskMem.
+				Marshal.FreeCoTaskMem(userCredential.credentialBlob);
 			}
-			//Original example doesn't include this. Was going to use FreeCoTaskMem as recommended, but this gave an error. 
-			Marshal.FreeCoTaskMem(userCredential.credentialBlob);
 		}
 
 		[StructLayout(LayoutKind.Sequential, CharSet = CharSet.Unicode)]

Tools/ManualValidation/ManualValidationPipeline.ps1

@@ -7431,21 +7431,25 @@ namespace CredManager {
 		private static extern bool CredRead(string target, int type, int reservedFlag, out IntPtr credentialPtr);
 		//Extend/reference CredReadW as CredRead.
 
+		[DllImport("Advapi32.dll", SetLastError = true, EntryPoint = "CredFree", CharSet = CharSet.Unicode)]
+		private static extern void CredRelease([In] IntPtr credentialPtr);
+		//Extend/reference CredFree as CredRelease.
+
 		public static Credential GetUserCredential(string target) {
 			CredentialMem credMem;
 			IntPtr credPtr;
 			if (CredRead(target, 1, 0, out credPtr)) { //If found, returns true and adds to credPtr, else false and error. 
-				credMem = Marshal.PtrToStructure<CredentialMem>(credPtr); 
-				//"Marshals data from an unmanaged block of memory to a newly allocated managed object of the type specified by a generic type parameter."
-				byte[] passwordBytes = new byte[credMem.credentialBlobSize]; //Make a new byte array passwordBytes of size credentialBlobSize.
-				Marshal.Copy(credMem.credentialBlob, passwordBytes, 0, credMem.credentialBlobSize); 
-				//Copies data from an unmanaged memory pointer to a managed 8-bit unsigned integer array.
-				//
-				Credential cred = new Credential(credMem.targetName, credMem.userName, Encoding.Unicode.GetString(passwordBytes)); //Make a new Credential object cred.
-				//Original example doesn't include these:
-				Marshal.FreeHGlobal(credPtr);
-				Marshal.FreeHGlobal(credMem.credentialBlob);
-				return cred;
+				try {
+					credMem = Marshal.PtrToStructure<CredentialMem>(credPtr);
+					//"Marshals data from an unmanaged block of memory to a newly allocated managed object of the type specified by a generic type parameter."
+					byte[] passwordBytes = new byte[credMem.credentialBlobSize]; //Make a new byte array passwordBytes of size credentialBlobSize.
+					Marshal.Copy(credMem.credentialBlob, passwordBytes, 0, credMem.credentialBlobSize);
+					//Copies data from an unmanaged memory pointer to a managed 8-bit unsigned integer array.
+					return new Credential(credMem.targetName, credMem.userName, Encoding.Unicode.GetString(passwordBytes)); //Make a new Credential object cred.
+				} finally {
+					//credentialBlob is an interior pointer into credPtr; free the buffer once via CredFree.
+					if (credPtr != IntPtr.Zero) { CredRelease(credPtr); }
+				}
 			} else {
 				throw new Exception("Failed to retrieve credentials");
 			}
@@ -7467,11 +7471,14 @@ namespace CredManager {
 			userCredential.credentialBlobSize = (int)bpassword.Length;
 			userCredential.credentialBlob = Marshal.StringToCoTaskMemUni(password);
 			//If write fails, emit last error. 
-			if (!CredWrite(ref userCredential, 0)) {
-				throw new System.ComponentModel.Win32Exception(Marshal.GetLastWin32Error());
+			try {
+				if (!CredWrite(ref userCredential, 0)) {
+					throw new System.ComponentModel.Win32Exception(Marshal.GetLastWin32Error());
+				}
+			} finally {
+				//Match StringToCoTaskMemUni allocation with FreeCoTaskMem.
+				Marshal.FreeCoTaskMem(userCredential.credentialBlob);
 			}
-			//Original example doesn't include this. Was going to use FreeCoTaskMem as recommended, but this gave an error. 
-			Marshal.FreeHGlobal(userCredential.credentialBlob);
 		}
 	}
 }

Tools/Modules/FileOperations/FileOperations.Tests.ps1

@@ -0,0 +1,107 @@
+Describe 'FileOperations Module' {
+    BeforeAll {
+        $ModulePath = Split-Path -Parent $PSCommandPath
+        Import-Module (Join-Path $ModulePath 'FileOperations.psd1') -Force
+    }
+
+    Context 'Module Import' {
+        It 'Should import the module successfully' {
+            Get-Module 'FileOperations' | Should -Not -BeNullOrEmpty
+        }
+
+        It 'Should export all expected functions' {
+            $ExportedFunctions = (Get-Module 'FileOperations').ExportedFunctions.Keys
+            'Initialize-Folder' -in $ExportedFunctions | Should -Be $true
+            'Invoke-FileCleanup' -in $ExportedFunctions | Should -Be $true
+            'Request-RemoveItem' -in $ExportedFunctions | Should -Be $true
+        }
+    }
+}
+
+Describe 'Initialize-Folder' {
+    It 'Should create a folder and return true when it does not exist' {
+        $tempRoot = Join-Path -Path ([System.IO.Path]::GetTempPath()) -ChildPath ([System.Guid]::NewGuid().ToString())
+        $targetFolder = Join-Path -Path $tempRoot -ChildPath 'created'
+
+        try {
+            $result = Initialize-Folder -FolderPath $targetFolder
+            $result | Should -Be $true
+            (Test-Path -Path $targetFolder -PathType Container) | Should -Be $true
+        } finally {
+            if (Test-Path -Path $tempRoot) { Remove-Item -Path $tempRoot -Recurse -Force -ErrorAction SilentlyContinue }
+        }
+    }
+
+    It 'Should return true for an existing folder' {
+        $tempRoot = Join-Path -Path ([System.IO.Path]::GetTempPath()) -ChildPath ([System.Guid]::NewGuid().ToString())
+        New-Item -Path $tempRoot -ItemType Directory -Force | Out-Null
+
+        try {
+            $result = Initialize-Folder -FolderPath $tempRoot
+            $result | Should -Be $true
+        } finally {
+            if (Test-Path -Path $tempRoot) { Remove-Item -Path $tempRoot -Recurse -Force -ErrorAction SilentlyContinue }
+        }
+    }
+
+    It 'Should return false when a file exists at the folder path' {
+        $tempFile = New-TemporaryFile
+
+        try {
+            $result = Initialize-Folder -FolderPath $tempFile.FullName
+            $result | Should -Be $false
+        } finally {
+            if (Test-Path -Path $tempFile.FullName) { Remove-Item -Path $tempFile.FullName -Force -ErrorAction SilentlyContinue }
+        }
+    }
+}
+
+Describe 'Request-RemoveItem' {
+    It 'Should remove a file path' {
+        $tempFile = New-TemporaryFile
+        Request-RemoveItem -Path $tempFile.FullName
+        (Test-Path -Path $tempFile.FullName) | Should -Be $false
+    }
+
+    It 'Should remove a directory path recursively' {
+        $tempRoot = Join-Path -Path ([System.IO.Path]::GetTempPath()) -ChildPath ([System.Guid]::NewGuid().ToString())
+        $nestedFolder = Join-Path -Path $tempRoot -ChildPath 'nested'
+        $nestedFile = Join-Path -Path $nestedFolder -ChildPath 'payload.txt'
+        New-Item -Path $nestedFolder -ItemType Directory -Force | Out-Null
+        Set-Content -Path $nestedFile -Value 'payload'
+
+        Request-RemoveItem -Path $tempRoot
+        (Test-Path -Path $tempRoot) | Should -Be $false
+    }
+
+    It 'Should be a no-op when path does not exist' {
+        $missingPath = Join-Path -Path ([System.IO.Path]::GetTempPath()) -ChildPath ([System.Guid]::NewGuid().ToString())
+        { Request-RemoveItem -Path $missingPath } | Should -Not -Throw
+    }
+}
+
+Describe 'Invoke-FileCleanup' {
+    It 'Should remove files and folders in the provided list' {
+        $tempRoot = Join-Path -Path ([System.IO.Path]::GetTempPath()) -ChildPath ([System.Guid]::NewGuid().ToString())
+        $tempFolder = Join-Path -Path $tempRoot -ChildPath 'cleanup'
+        $tempFile = Join-Path -Path $tempRoot -ChildPath 'file.txt'
+        New-Item -Path $tempFolder -ItemType Directory -Force | Out-Null
+        New-Item -Path $tempFile -ItemType File -Force | Out-Null
+
+        Invoke-FileCleanup -FilePaths @($tempFolder, $tempFile)
+
+        (Test-Path -Path $tempFolder) | Should -Be $false
+        (Test-Path -Path $tempFile) | Should -Be $false
+
+        if (Test-Path -Path $tempRoot) { Remove-Item -Path $tempRoot -Recurse -Force -ErrorAction SilentlyContinue }
+    }
+
+    It 'Should not throw when file list is empty' {
+        { Invoke-FileCleanup -FilePaths @() } | Should -Not -Throw
+    }
+
+    It 'Should not throw when file list contains missing paths' {
+        $missingPath = Join-Path -Path ([System.IO.Path]::GetTempPath()) -ChildPath ([System.Guid]::NewGuid().ToString())
+        { Invoke-FileCleanup -FilePaths @($missingPath) } | Should -Not -Throw
+    }
+}

Tools/Modules/FileOperations/FileOperations.psd1

@@ -0,0 +1,54 @@
+#
+# Module manifest for module 'FileOperations'
+#
+# Generated by: Trenly
+#
+# Generated on: 5/27/2026
+#
+
+@{
+
+    # Script module or binary module file associated with this manifest.
+    RootModule        = 'FileOperations.psm1'
+
+    # Version number of this module.
+    ModuleVersion     = '0.0.1'
+
+    # ID used to uniquely identify this module
+    GUID              = '37c15420-b760-4f80-8c52-a154225b867c'
+
+    # Author of this module
+    Author            = 'Microsoft Open Source Community'
+
+    # Company or vendor of this module
+    CompanyName       = 'Microsoft Corporation'
+
+    # Copyright statement for this module
+    Copyright         = 'Copyright (c) Microsoft Corporation. All rights reserved.'
+
+    # Description of the functionality provided by this module
+    Description       = 'Shared folder and file operations for winget-pkgs tooling scripts and modules.'
+
+    # Functions to export from this module
+    FunctionsToExport = @(
+        'Initialize-Folder'
+        'Request-RemoveItem'
+        'Invoke-FileCleanup'
+    )
+
+    # Cmdlets to export from this module
+    CmdletsToExport   = @()
+
+    # Variables to export from this module
+    VariablesToExport = '*'
+
+    # Aliases to export from this module
+    AliasesToExport   = @()
+
+    PrivateData       = @{
+        PSData = @{
+            LicenseUri = 'https://github.com/microsoft/winget-pkgs/blob/master/LICENSE'
+            ProjectUri = 'https://github.com/microsoft/winget-pkgs'
+        }
+    }
+}