sys-apps/turnstile: add post-install warning for PAM config#4
Merged
WavyEbuilder merged 1 commit intomainfrom May 2, 2025
unknown repository
Merged
sys-apps/turnstile: add post-install warning for PAM config#4WavyEbuilder merged 1 commit intomainfrom unknown repository
WavyEbuilder merged 1 commit intomainfrom
unknown repository
Conversation
Owner
|
I'll review this soon. |
WavyEbuilder
requested changes
Apr 27, 2025
Owner
WavyEbuilder
left a comment
WavyEbuilder
left a comment
There was a problem hiding this comment.
The ewarn message explicitly mentions dinit, but turnstile supports more than just dinit as a backend (and so does this ebuild) - it is not directly tied to sys-apps/dinit. Could you change the message to be a bit more generic, something along the lines of "To enable session tracking" or similar please?
Author
|
No problem! |
WavyEbuilder
approved these changes
May 2, 2025
Owner
WavyEbuilder
left a comment
WavyEbuilder
left a comment
There was a problem hiding this comment.
While hopefully we'll be able to drop turnstile from the overlay at some point, for now this looks good. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.