-
Notifications
You must be signed in to change notification settings - Fork 1
Add image_type key to spec
#17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughAdds an optional Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Core as OMEArrow Core
participant Ingest as Ingest Layer
participant Storage as Storage (Parquet/Zarr/TIFF)
User->>Core: instantiate OMEArrow(data, image_type="label")
Core->>Ingest: dispatch to loader (from_numpy/from_tiff/from_ome_zarr/...)
Ingest->>Ingest: to_ome_arrow(..., image_type="label") -> build record with image_type
Ingest->>Storage: write/read record (may include image_type or None)
Storage->>Core: return loaded record
Core->>User: return OMEArrow instance with image_type preserved
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
✏️ Tip: You can disable this entire section by setting Comment |
MikeLippincott
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Exciting to see this work!
|
Thanks @MikeLippincott ! |
Description
This PR adds an
image_typekey to the spec, enabling one to indicate what type of image will be included. This is intended to help with downstream applications where one might want to differentiate from a label (masks, outlines, etc), raw image, or others.Closes #16
What kind of change(s) are included?
Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.
Summary by CodeRabbit
New Features
Backward Compatibility
Tests
Chores
✏️ Tip: You can customize this high-level summary in your review settings.