Setup github actions for testing #4
Conversation
This is the basic setup of github actions to run pytest whenever merging, or on pull_request.
d33bs
left a comment
d33bs
left a comment
There was a problem hiding this comment.
Nice job! This looks like a useful change. I made a few comments up for your consideration, let me know if you have any questions about anything.
I noticed the tests fail currently because there's no pyproject.toml file to reference yet. You might consider pulling these changes into #1 after a merge to main, or possibly making the merge target of this PR the branch which #1 is based on (not sure if that's possible, but could be worth a try).
Would the work here pertain to #3 ? If so, consider updating the description of the PR to include something like closes #3 to help automatically close the issue when the PR is merged (only if you feel it should be closed after merge, otherwise you could reference #3, etc.).
|
Thanks @d33bs, merging now! |
This is the basic setup of github actions to run pytest whenever merging, or on a pull_request with main as the target branch. This is intended to test the code to ensure proper functioning of the pairwise_compare tool. I still need to commit additional changes, so I expect failures until then. I wanted to include this github actions functionality before I commit these changes to the currently open pr on the development branch. Please let me know if you have any constructive feedback.