Improve dock #322
Open
Improve dock #322
+31
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trigg
reviewed
Jan 2, 2026
soreau
force-pushed
the
improve-dock
branch
2 times, most recently
from
874db5b to
dd003b1
Compare
Contributor
|
LGTM. Would you rather put 'active' default css in a different PR or this one? |
Member
Author
Thanks for your review. If I can work up some css that does what I want, I think it would make sense to put it in this PR. |
This effectively removes the black border around active application icons while still setting a class so users can style them.
If we set exclusive zone but do not cover the entire zone as is the case with dock, it pushes all the surfaces out of the way, so that the only thing that's left is the background clear color. It's much better to just not set the exclusive zone at all for dock, because it's more aesthetically pleasing while still allowing to click to the surface below, on either side of the dock.
Member
Author
|
@trigg I'm done fiddling with the activated css, it just renders a white line beneath the active button icon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.