fix contents of encapsulated strings being lexed #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a similar issue as in #10 where creating a window rule like
on created if app_id is "f.exe" then maximizewould lead to the following error:This is because the lexer tries to parse the contents of encapsulated literals.
The only issue I can see with the solution is that it might not handle encapsulated character literals properly? Although I couldn't find a place where character literals are used.
Apart from that it doesn't really make sense to try to parse for example
"false"as a boolean instead of a window with the title "false".It might make sense to handle only literals encapsulated with
"differently since at least the comments inlexer.hppimply that it's supposed to be generic and there might eventually be a use case for encapsulated literals that aren't strings.