Skip to content

Update pi-subagents fork to upstream v0.12.0#2

Merged
nodnarbnitram merged 6 commits into
mainfrom
update-pi-subagents-v0.12.0
Jun 30, 2026
Merged

Update pi-subagents fork to upstream v0.12.0#2
nodnarbnitram merged 6 commits into
mainfrom
update-pi-subagents-v0.12.0

Conversation

@nodnarbnitram

@nodnarbnitram nodnarbnitram commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Update @weshipwork/pi-subagents from upstream @tintinweb/pi-subagents v0.10.3 to v0.12.0.
  • Preserve the WeShip.work package identity and Mirror mode observation seam for @weshipwork/pi-herd.
  • Publish fork metadata as 0.12.0-mirror.0 and document the tracked upstream tag in README.mirror.md.
  • Update non-fork packages @weshipwork/pi-herd and @weshipwork/pi-herdr to validate against Pi 0.80.2 dev dependencies.

Validation

  • pnpm --filter @weshipwork/pi-subagents lint
  • pnpm --filter @weshipwork/pi-subagents test:mirror
  • pnpm --filter @weshipwork/pi-subagents check
  • pnpm --filter @weshipwork/pi-herdr check
  • pnpm --filter @weshipwork/pi-herd check
  • pnpm check

@greptile-apps

greptile-apps Bot commented Jun 26, 2026

Copy link
Copy Markdown

Greptile Summary

This PR updates the pi-subagents fork to the upstream v0.12.0 line. The main changes are:

  • Bumps the fork package version and Pi dev dependencies.
  • Adds upstream FleetView UI behavior and settings wiring.
  • Adds persisted subagent session frontmatter support.
  • Adds foreground completion events and transcript output logging.
  • Updates mirror README and package documentation for the new fork release.

Confidence Score: 4/5

This is close, but the session-switch cleanup should be fixed before merging.

  • Old completion notification timers can survive a session switch.
  • Group completion timers can also deliver old results after the new session is active.
  • The result preservation path works for unread records, but follow-up delivery is not bounded to the original session.

packages/pi-subagents/src/index.ts

Important Files Changed

Filename Overview
packages/pi-subagents/src/index.ts Adds FleetView wiring and changes session transition cleanup, but old completion notification state can still cross into a new session.
packages/pi-subagents/src/agent-manager.ts Adds foreground completion callbacks, output setup hooks, and unread-result preservation for session transitions.
packages/pi-subagents/src/ui/fleet-list.ts Adds the below-editor FleetView navigation UI for running and recently finished subagents.
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
packages/pi-subagents/src/index.ts:481-482
**Session Timers Survive** When an agent completes just before a session switch, `clearCompleted(true)` keeps the unread old record but this handler leaves the pending notification timers and group-join timers active. Those timers can fire after the new session is active and call `pi.sendMessage` with `deliverAs: "followUp"`, so an old subagent result can still trigger a turn in the new conversation. The session boundary needs to cancel or session-scope follow-up delivery for old work while keeping the result readable through `get_subagent_result`.

Reviews (5): Last reviewed commit: "Revert "Cancel pending subagent nudges o..." | Re-trigger Greptile

Comment thread packages/pi-subagents/src/index.ts
Comment thread packages/pi-subagents/src/index.ts
Comment thread packages/pi-subagents/src/index.ts
Comment thread packages/pi-subagents/src/index.ts Outdated
Comment thread packages/pi-subagents/src/index.ts
@nodnarbnitram
nodnarbnitram merged commit 7f86a29 into main Jun 30, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant