Update pi-subagents fork to upstream v0.12.0#2
Merged
Conversation
Greptile SummaryThis PR updates the
Confidence Score: 4/5This is close, but the session-switch cleanup should be fixed before merging.
packages/pi-subagents/src/index.ts
|
| Filename | Overview |
|---|---|
| packages/pi-subagents/src/index.ts | Adds FleetView wiring and changes session transition cleanup, but old completion notification state can still cross into a new session. |
| packages/pi-subagents/src/agent-manager.ts | Adds foreground completion callbacks, output setup hooks, and unread-result preservation for session transitions. |
| packages/pi-subagents/src/ui/fleet-list.ts | Adds the below-editor FleetView navigation UI for running and recently finished subagents. |
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
packages/pi-subagents/src/index.ts:481-482
**Session Timers Survive** When an agent completes just before a session switch, `clearCompleted(true)` keeps the unread old record but this handler leaves the pending notification timers and group-join timers active. Those timers can fire after the new session is active and call `pi.sendMessage` with `deliverAs: "followUp"`, so an old subagent result can still trigger a turn in the new conversation. The session boundary needs to cancel or session-scope follow-up delivery for old work while keeping the result readable through `get_subagent_result`.
Reviews (5): Last reviewed commit: "Revert "Cancel pending subagent nudges o..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@weshipwork/pi-subagentsfrom upstream@tintinweb/pi-subagentsv0.10.3tov0.12.0.@weshipwork/pi-herd.0.12.0-mirror.0and document the tracked upstream tag inREADME.mirror.md.@weshipwork/pi-herdand@weshipwork/pi-herdrto validate against Pi0.80.2dev dependencies.Validation
pnpm --filter @weshipwork/pi-subagents lintpnpm --filter @weshipwork/pi-subagents test:mirrorpnpm --filter @weshipwork/pi-subagents checkpnpm --filter @weshipwork/pi-herdr checkpnpm --filter @weshipwork/pi-herd checkpnpm check