fix: openapi spec field ordering, ACDCs and other misc bugs#428
Open
iFergal wants to merge 10 commits intoWebOfTrust:mainfrom
Open
fix: openapi spec field ordering, ACDCs and other misc bugs#428iFergal wants to merge 10 commits intoWebOfTrust:mainfrom
iFergal wants to merge 10 commits intoWebOfTrust:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #428 +/- ##
=======================================
Coverage 87.74% 87.74%
=======================================
Files 26 26
Lines 5808 5801 -7
=======================================
- Hits 5096 5090 -6
+ Misses 712 711 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kentbull
approved these changes
Mar 27, 2026
kentbull
approved these changes
Mar 28, 2026
Collaborator
|
Please rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The conversion from fielddom to dataclass of ACDC was missing overrides for edges and rules which are always expanded when returned from the API. When compacted variants come in, can be updated to a union with a string but this is more straight forward right now.
ancatcis actually always a list of size 1.Also fixed field orderings that were lost when fields were optional, or inserted via
altsfrom fielddom conversion. Now top-level ACDC fields keep their order in the OpenAPI spec.--
Edit: Also realised:
RegStateRecordfrom keripy as that isn't as specific on enums etc.