fix: promote multi-stage build args to ENV so they propagate across stages#90
Merged
Merged
Conversation
ValeriiSudakov
approved these changes
Jun 26, 2026
KharchenkoMaks
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build args declared in the wpr_dependencies stage (WPR_FILES_DIR, WPR_APP_INSTALL_DIR, WPR_USER_NAME) did not reach the later wpr_installer and wpr_service stages. An ARG goes out of scope at the end of the stage where it is declared, so in the child stages these variables resolved to empty.
This reproduces on build engines that do not inherit parent-stage ARG defaults (Kaniko, buildah, classic builder)
The fix promotes these three to ENV in the base stage. Unlike ARG, ENV is inherited across FROM, so the values reach all stages on any build engine, without redeclaring each ARG per stage. Applied to both Dockerfile and Dockerfile.redhat. Dockerfile.ubuntu-prebuilt already declares its args per stage and was not affected.