Skip to content

Conversation

@muzammalrahim
Copy link
Contributor

Proposed changes

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • [x ] I have described the changes in the commit messages.

Other information

@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #498 (2bffc50) into master (5fb7f1b) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #498      +/-   ##
==========================================
- Coverage   83.54%   83.49%   -0.05%     
==========================================
  Files          26       26              
  Lines        2479     2484       +5     
  Branches      252      253       +1     
==========================================
+ Hits         2071     2074       +3     
- Misses        315      316       +1     
- Partials       93       94       +1     

@nijel
Copy link
Member

nijel commented Feb 15, 2021

There are some code formatting issues left. In case the pull request would allow edits (see https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests), the pre-commit.ci service would do the formatting for you...

@muzammalrahim
Copy link
Contributor Author

There are some code formatting issues left. In case the pull request would allow edits (see https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests), the pre-commit.ci service would do the formatting for you...

Okay let me check!

@nijel nijel closed this Feb 15, 2021
@nijel nijel reopened this Feb 15, 2021
@muzammalrahim
Copy link
Contributor Author

There are some code formatting issues left. In case the pull request would allow edits (see https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests), the pre-commit.ci service would do the formatting for you...

I have pre commit installed already, it's passing the checks from my side but it fails on Git.

@nijel
Copy link
Member

nijel commented Feb 16, 2021

You can ignore the DeepSource: Python errors, it sometimes fails to properly detect changes in the source and complains on errors which were present in the repository before.

@muzammalrahim
Copy link
Contributor Author

You can ignore the DeepSource: Python errors, it sometimes fails to properly detect changes in the source and complains on errors which were present in the repository before.

Okay, other than that all other checks managed to pass. Should i create the PR for previous fixes now?

@nijel nijel merged commit 07812ae into WeblateOrg:master Feb 16, 2021
@nijel
Copy link
Member

nijel commented Feb 16, 2021

Merged, thanks for your contribution!

We can now focus on getting #486 merged as well.

@nijel
Copy link
Member

nijel commented Feb 16, 2021

Sorry, I meant #474...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants