-
-
Notifications
You must be signed in to change notification settings - Fork 55
User section improvements #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* User page - service section design changes Co-authored-by: AyazYousafxai <ayazpk6630@gmail.com>
These should be merged with #438
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
Codecov Report
@@ Coverage Diff @@
## master #517 +/- ##
==========================================
- Coverage 83.57% 83.53% -0.05%
==========================================
Files 26 27 +1
Lines 2484 2490 +6
Branches 253 253
==========================================
+ Hits 2076 2080 +4
- Misses 315 316 +1
- Partials 93 94 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 You fixed the issue(s)! Great work.
This can be a normal form...
|
This pull request introduces 5 alerts when merging 3312244 into d6043d2 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 You fixed the issue(s)! Great work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 You fixed the issue(s)! Great work.
- adding support texts - correcting swapped images
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 You fixed the issue(s)! Great work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 You fixed the issue(s)! Great work.
small corrections
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 You fixed the issue(s)! Great work.
Proposed changes
Adding fixes on top of #474
Checklist
Other information