Skip to content

Conversation

@nijel
Copy link
Member

@nijel nijel commented Mar 1, 2021

Proposed changes

Adding fixes on top of #474

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

muzammalrahim and others added 3 commits March 1, 2021 12:52
* User page - service section design changes

Co-authored-by: AyazYousafxai <ayazpk6630@gmail.com>
These should be merged with #438
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

@nijel nijel mentioned this pull request Mar 1, 2021
5 tasks
@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #517 (c6a2fdf) into master (d6043d2) will decrease coverage by 0.04%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##           master     #517      +/-   ##
==========================================
- Coverage   83.57%   83.53%   -0.05%     
==========================================
  Files          26       27       +1     
  Lines        2484     2490       +6     
  Branches      253      253              
==========================================
+ Hits         2076     2080       +4     
- Misses        315      316       +1     
- Partials       93       94       +1     

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

This can be a normal form...
@lgtm-com
Copy link

lgtm-com bot commented Mar 1, 2021

This pull request introduces 5 alerts when merging 3312244 into d6043d2 - view on LGTM.com

new alerts:

  • 5 for Duplicate HTML element attributes

@nijel nijel changed the title User section imporvements User section improvements Mar 1, 2021
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

- adding support texts
- correcting swapped images
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

small corrections
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@nijel nijel merged commit 1f7e358 into master Mar 2, 2021
@nijel nijel deleted the future branch March 2, 2021 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants