Integrated DPC native and triplet pipeline density estimation functions#31
Open
sdentro wants to merge 3 commits intoWedge-lab:devfrom
Open
Integrated DPC native and triplet pipeline density estimation functions#31sdentro wants to merge 3 commits intoWedge-lab:devfrom
sdentro wants to merge 3 commits intoWedge-lab:devfrom
Conversation
Collaborator
Author
|
The second and third commits to this contains what I'm referring to as "phase 3": The code that was previously not yet included in the package. The final phase 4 will add docs and instructions on how to run the triplet pipeline via the package. Then this would be ready for release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is phase 2 of the integration of the triplet pipeline into the main DPC package. This now includes the density estimation code that will work in the triplet pipeline and is setup to seamlessly integrate into the standard code without any changes to pipelines to be done. Therefore, to test this new code, it should just run on any sample/case where the triplet pipeline is not required.
For the triplet pipeline, two output files are now slightly different. It either required changing the DPC package code, or a change to the triplet pipeline. I've opted for the latter. This will require a small change to the code that combines the triplet density output. This is underway and will come in phase 3. But for the sake of completeness, these files are different from the current separate triplet pipeline:
The last paragraph was more for information only. The changes in these commits should integrate without any adaptation of the regular pipeline required and I'm very happy to take feedback where it doesn't!