feat(admin): bulk edit filtered account selection#1335
Open
LvyuanW wants to merge 14 commits intoWei-Shaw:mainfrom
Open
feat(admin): bulk edit filtered account selection#1335LvyuanW wants to merge 14 commits intoWei-Shaw:mainfrom
LvyuanW wants to merge 14 commits intoWei-Shaw:mainfrom
Conversation
重构错误详情弹窗和错误日志表格中的用户/账户信息显示逻辑，使其更清晰和完整。主要变更包括： - 在错误详情弹窗中，优先显示账户信息（针对上游错误），并在适当时显示次要的用户或账户信息 - 在错误日志表格中，优化用户和账户信息的显示优先级，并在主要显示用户信息时添加账户信息作为次要显示 - 新增格式化函数统一处理用户和账户标识的显示逻辑，提高代码复用性 - 扩展上游事件详情网格为三列布局，增加账户信息显示
添加 OpsErrorLogTable 和 OpsErrorDetailModal 组件的单元测试，覆盖用户信息展示逻辑 - 测试表格中请求错误和上游错误的用户与账号名显示优先级 - 测试详情模态框中数据加载和关联上游错误的账号信息展示
LvyuanW
changed the title
# Conflicts: # frontend/src/views/admin/ops/components/OpsErrorDetailModal.vue # frontend/src/views/admin/ops/components/OpsErrorLogTable.vue
# Conflicts: # backend/internal/handler/admin/account_data.go # backend/internal/handler/admin/account_handler.go # frontend/src/views/admin/AccountsView.vue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
The admin account page only tracked explicit in-memory
account_idsfrom the current page, and the bulk edit API only acceptedaccount_ids. That made it impossible to bulk edit all filtered accounts, and the modal could infer editable fields from an incomplete sample instead of the true target set.Impact
Validation
env GOCACHE=/tmp/sub2api-go-cache go test ./internal/handler/admin ./internal/server/...pnpm exec vitest run src/components/account/__tests__/BulkEditAccountModal.spec.ts src/components/admin/account/__tests__/AccountBulkActionsBar.spec.tspnpm exec vue-tsc --noEmit