Skip to content

fix(contracts): restore snake_case field names in the exec-channel union#263

Merged
Yambr merged 1 commit into
mainfrom
fix/exec-channel-snake-case
Jun 10, 2026
Merged

fix(contracts): restore snake_case field names in the exec-channel union#263
Yambr merged 1 commit into
mainfrom
fix/exec-channel-snake-case

Conversation

@Yambr

@Yambr Yambr commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Restores three handshake field names to the schema's universal snake_case convention: env_varsenv, boundPidbound_pid, supports_tracesupports_traces.

boundPid was the only camelCase property in the schema. Both language bindings already declare these fields as env / bound_pid / supports_traces and carried per-field rename attributes to compensate; the existing prose in docs/future-architecture also references supports_traces. Frozen-contract changes ride in dedicated PRs.

The companion ocu-sandbox PR updates the embedded schema copies, fixtures, and both bindings; the byte-identity gate there verifies against this file.

🤖 Generated with Claude Code

Summary by CodeRabbit

Chores

  • Updated Exec WebSocket control protocol schema with normalized property names: env_varsenv and boundPidbound_pid.
  • Renamed trace-negotiation flag from supports_trace to supports_traces across connection capabilities and trace-event references for consistency.

Three handshake fields diverged from the schema's universal snake_case
convention and from the field names both language bindings declare:
env_vars -> env, boundPid -> bound_pid, supports_trace -> supports_traces.
boundPid was the only camelCase property in the schema; the bindings carry
these fields as env / bound_pid / supports_traces and needed per-field
rename attributes to compensate. Frozen-contract changes ride in dedicated
PRs, not release consolidations.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 344f0459-d338-4295-b605-67a1c5c48b4d

📥 Commits

Reviewing files that changed from the base of the PR and between 93ee911 and c3e0ed6.

📒 Files selected for processing (1)
  • contracts/exec/exec-channel.schema.json

Walkthrough

The exec-channel WebSocket protocol schema receives coordinated naming updates: CreateProcess properties are renamed for consistency (env_varsenv, boundPidbound_pid), and the trace-negotiation capability field is renamed from supports_trace to supports_traces with matching updates to all comments and documentation references.

Changes

Schema Naming Standardization

Layer / File(s) Summary
CreateProcess property renames
contracts/exec/exec-channel.schema.json
CreateProcess schema properties are renamed from env_vars to env and from boundPid to bound_pid for naming convention consistency.
Trace capability field rename and documentation
contracts/exec/exec-channel.schema.json
The boolean trace-negotiation field in ConnectionCapabilities is renamed from supports_trace to supports_traces. All referential comments in server-side and client-side TraceEvent definitions and open-questions documentation are updated to use the new field name.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: restoring snake_case naming conventions in the exec-channel schema by renaming env_vars, boundPid, and supports_trace fields.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/exec-channel-snake-case

Warning

Review ran into problems

🔥 Problems

Stopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a @coderabbit review after the pipeline has finished.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Yambr Yambr merged commit 73e82c6 into main Jun 10, 2026
24 checks passed
@Yambr Yambr deleted the fix/exec-channel-snake-case branch June 10, 2026 19:19
Yambr added a commit to Wide-Moat/ocu-sandbox that referenced this pull request Jun 10, 2026
Sync with the canonical schema (Wide-Moat/open-computer-use#263):
env_vars -> env, boundPid -> bound_pid, supports_trace -> supports_traces.
boundPid was the only camelCase property in an otherwise snake_case
schema, and all three names forced per-field rename attributes because
the Rust and Go bindings already declare env / bound_pid /
supports_traces. Drops the serde renames, updates the Go JSON tags,
fixtures (both mirrors), and doc strings. No behavioral change.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant