fix(contracts): restore snake_case field names in the exec-channel union#263
Conversation
Three handshake fields diverged from the schema's universal snake_case convention and from the field names both language bindings declare: env_vars -> env, boundPid -> bound_pid, supports_trace -> supports_traces. boundPid was the only camelCase property in the schema; the bindings carry these fields as env / bound_pid / supports_traces and needed per-field rename attributes to compensate. Frozen-contract changes ride in dedicated PRs, not release consolidations. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe exec-channel WebSocket protocol schema receives coordinated naming updates: ChangesSchema Naming Standardization
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsStopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sync with the canonical schema (Wide-Moat/open-computer-use#263): env_vars -> env, boundPid -> bound_pid, supports_trace -> supports_traces. boundPid was the only camelCase property in an otherwise snake_case schema, and all three names forced per-field rename attributes because the Rust and Go bindings already declare env / bound_pid / supports_traces. Drops the serde renames, updates the Go JSON tags, fixtures (both mirrors), and doc strings. No behavioral change. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Restores three handshake field names to the schema's universal snake_case convention:
env_vars→env,boundPid→bound_pid,supports_trace→supports_traces.boundPidwas the only camelCase property in the schema. Both language bindings already declare these fields asenv/bound_pid/supports_tracesand carried per-field rename attributes to compensate; the existing prose indocs/future-architecturealso referencessupports_traces. Frozen-contract changes ride in dedicated PRs.The companion ocu-sandbox PR updates the embedded schema copies, fixtures, and both bindings; the byte-identity gate there verifies against this file.
🤖 Generated with Claude Code
Summary by CodeRabbit
Chores
env_vars→envandboundPid→bound_pid.supports_tracetosupports_tracesacross connection capabilities and trace-event references for consistency.